Skip to content

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Dec 19, 2023

This is a replicate of #355

@github-actions
Copy link

github-actions bot commented Dec 19, 2023

Copy link
Member

@shlff shlff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmcky . Hi @jstac and @oyamad , please find my reviews here.

new_x = self.A_hat @ x
error = np.max(np.abs(new_x - x))
x = new_x
x = np.array([self.A_hat[1, 0], self.A_hat[0, 1]])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
x = np.array([self.A_hat[1, 0], self.A_hat[0, 1]])
x = np.array([self.A_hat[0, 1], self.A_hat[1, 0]])

Please find experiment:

https://gist.github.com/shlff/02f5aac35f8793cdf08935e13174b131

where method with x = np.array([self.A_hat[0, 1], self.A_hat[1, 0]]) generates the same result as the original iterative method.

new_x = self.A_hat @ x
error = np.max(np.abs(new_x - x))
x = new_x
x = np.array([self.A_hat[1, 0], self.A_hat[0, 1]])
Copy link
Member

@shlff shlff Dec 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
x = np.array([self.A_hat[1, 0], self.A_hat[0, 1]])
x = np.array([self.A_hat[0, 1], self.A_hat[1, 0]])

Same here.

@mmcky
Copy link
Contributor Author

mmcky commented Dec 20, 2023

Closing as no longer required

@mmcky mmcky closed this Dec 20, 2023
@mmcky mmcky deleted the replica-pr355 branch December 20, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants