-
-
Notifications
You must be signed in to change notification settings - Fork 54
CI: add action to check code warnings #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mmcky
wants to merge
25
commits into
main
Choose a base branch
from
ci-warnings-action
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 19 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
6c084a8
CI: add action to check code warnings
mmcky 7ec8aae
update test after more development with copilot
mmcky 218e472
TST: force a FutureWarning
mmcky 8adb525
try report setting
mmcky e265e2a
enable github action permission to write to Issue
mmcky a3be496
enable reporting by setting fail-on-warning: false
mmcky 02e9052
set permissions for Issue and artifact upload
mmcky 3db8d0f
test new fail setup
mmcky 17ecb23
test new issue feature with small post in PR feed
mmcky 9595cf0
test new issue feature with automatic notification
mmcky e8416ad
final test of action @ main
mmcky 97add6b
remove @jstac
mmcky d4264c7
remove test case
mmcky 94735f7
test: comprehensive warning checks
mmcky 56041e3
Revert "remove test case"
mmcky 0168105
Revert "Revert "remove test case""
mmcky b76a005
FIX: setup fetching from branch
mmcky fdc0824
Merge branch 'main' into ci-warnings-action
mmcky 87ba05f
Merge branch 'main' into ci-warnings-action
mmcky 324056e
Update .github/workflows/ci.yml
mmcky 8cf653d
Merge branch 'main' into ci-warnings-action
mmcky ea8c6ce
Update .github/workflows/ci.yml
mmcky c39dc63
Update .github/workflows/ci.yml
mmcky d343910
tst: raise UserWarning
mmcky ee3b226
tst: raise UserWarning
mmcky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -5,6 +5,9 @@ on: | |||||
| jobs: | ||||||
| preview: | ||||||
| runs-on: "runs-on=${{ github.run_id }}/family=g4dn.2xlarge/image=quantecon_ubuntu2404/disk=large" | ||||||
| permissions: | ||||||
| issues: write | ||||||
| pull-requests: write | ||||||
| steps: | ||||||
| - uses: actions/checkout@v5 | ||||||
| with: | ||||||
|
|
@@ -72,6 +75,14 @@ jobs: | |||||
| shell: bash -l {0} | ||||||
| run: | | ||||||
| jb build lectures --path-output ./ -n -W --keep-going | ||||||
| - name: Check for Python warnings | ||||||
| uses: QuantEcon/meta/.github/actions/check-warnings@main | ||||||
mmcky marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||
| with: | ||||||
| html-path: './_build/html' | ||||||
| fail-on-warning: 'false' | ||||||
| create-issue: 'true' | ||||||
| issue-title: 'Python warnings found in code output' | ||||||
| notify: 'mmcky,HumphreyYang' | ||||||
|
||||||
| notify: 'mmcky,HumphreyYang' | |
| notify: '@QuantEcon/maintainers' |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.