Skip to content

Conversation

@bishmaybarik
Copy link
Member

@bishmaybarik bishmaybarik commented Oct 1, 2025

This PR fixes the following issues:

The issue was the following:

  • style guide review
  • fix full web links that are currently used across the lectures with a range of link text, doc links.

@bishmaybarik bishmaybarik self-assigned this Oct 1, 2025
@github-actions
Copy link

github-actions bot commented Oct 1, 2025

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app (fb4ddb0)

📚 Changed Lecture Pages: mix_model

@github-actions
Copy link

github-actions bot commented Oct 1, 2025

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app (7cba5eb)

📚 Changed Lecture Pages: mix_model

@bishmaybarik bishmaybarik marked this pull request as ready for review October 1, 2025 10:44
@bishmaybarik bishmaybarik requested a review from mmcky October 1, 2025 10:44
@bishmaybarik
Copy link
Member Author

hi @mmcky , I have made some changes and made sure I pushed everything to this branch. although I have checked it myself, it'll be nice to have it reviewed by you :-)

if there are further issues with the lecture, please let me know!

@bishmaybarik bishmaybarik added ready and removed in-work labels Oct 1, 2025
@bishmaybarik bishmaybarik changed the title [FIX]: Improve the mix_model.md lecture [mix_model.md]: Fix issues and improve the lecture Oct 1, 2025
@bishmaybarik bishmaybarik changed the title [mix_model.md]: Fix issues and improve the lecture [mix_model]: Fix issues and improve the lecture Oct 1, 2025
@github-actions
Copy link

github-actions bot commented Oct 1, 2025

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app (67c3a4b)

📚 Changed Lecture Pages: mix_model

@bishmaybarik bishmaybarik requested a review from Copilot October 6, 2025 08:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes formatting, style, and link issues in the mix_model lecture to align with style guidelines and improve readability. The changes primarily involve converting raw URLs to proper markdown links, fixing capitalization in headings, and correcting a few punctuation errors.

Key Changes

  • Converted raw web links to proper markdown format with descriptive text
  • Fixed capitalization in section headings to follow consistent style
  • Made minor punctuation and text corrections

@bishmaybarik
Copy link
Member Author

hi @mmcky, may I know if you have any thoughts on this? I would humbly request you to review this whenever you have the time :-)

Copy link
Member

@HumphreyYang HumphreyYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @bishmaybarik! These are great changes!

Noted that if we use

{doc}`lecture_name`

It will give use a hyperlink with the lecture title. So we can reduce the usage of "this lecture" in the lectures.

There are also a few lines of code that's touching 80-character limit so please have a go at breaking them into two lines!

Please let me know what you think.



Our second method uses a uniform distribution and the following fact that we also described and used in the quantecon lecture <https://python.quantecon.org/prob_matrix.html>:
Our second method uses a uniform distribution and the following fact that we also described and used in the [quantecon lecture on elementary probability with matrices](https://python.quantecon.org/prob_matrix.html):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Our second method uses a uniform distribution and the following fact that we also described and used in the [quantecon lecture on elementary probability with matrices](https://python.quantecon.org/prob_matrix.html):
Our second method uses a uniform distribution and the following fact that we also described and used in {doc}`prob_matrix`:

The reason is that now the wage sequence is actually described by a different statistical model.
The reason is that now the wage sequence is actually described by a different statistical model.

Thus, we change the {doc}`quantecon lecture <likelihood_bayes>` specification in the following way.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Thus, we change the {doc}`quantecon lecture <likelihood_bayes>` specification in the following way.
Thus, we change the specification in {doc}`likelihood_bayes` in the following way.

each period, though the agent doesn't know the mixing parameter.

Our first type of agent applies the learning algorithm described in {doc}`this quantecon lecture <likelihood_bayes>`.
Our first type of agent applies the learning algorithm described in {doc}`this quantecon lecture <likelihood_bayes>`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Our first type of agent applies the learning algorithm described in {doc}`this quantecon lecture <likelihood_bayes>`.
Our first type of agent applies the learning algorithm described in {doc}`likelihood_bayes`.

Remember that our type 1 agent uses the wrong statistical model, thinking that nature mixed between $f$ and $g$ once and for all at time $-1$.

The type 1 agent thus uses the learning algorithm studied in {doc}`this quantecon lecture <likelihood_bayes>`.
The type 1 agent thus uses the learning algorithm studied in {doc}`this quantecon lecture <likelihood_bayes>`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The type 1 agent thus uses the learning algorithm studied in {doc}`this quantecon lecture <likelihood_bayes>`.
The type 1 agent thus uses the learning algorithm studied in {doc}`likelihood_bayes`.


We'll assume that the person starts out with a prior probability $\pi_0(\alpha)$ on
We'll assume that the agent starts out with a prior probability $\pi_0(\alpha)$ on
$\alpha \in (0,1)$ where the prior has one of the forms that we deployed in {doc}`this quantecon lecture <bayes_nonconj>`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$\alpha \in (0,1)$ where the prior has one of the forms that we deployed in {doc}`this quantecon lecture <bayes_nonconj>`.
$\alpha \in (0,1)$ where the prior has one of the forms that we deployed in {doc}`bayes_nonconj`.

We'll create graphs of the posterior $\pi_t(\alpha)$ as
$t \rightarrow +\infty$ corresponding to ones presented in the quantecon lecture <https://python.quantecon.org/bayes_nonconj.html>.
We'll create graphs of the posterior $\pi_t(\alpha)$ as
$t \rightarrow +\infty$ corresponding to ones presented in the [quantecon lecture on Bayesian nonconjugate priors](https://python.quantecon.org/bayes_nonconj.html).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$t \rightarrow +\infty$ corresponding to ones presented in the [quantecon lecture on Bayesian nonconjugate priors](https://python.quantecon.org/bayes_nonconj.html).
$t \rightarrow +\infty$ corresponding to ones presented in {doc}`bayes_nonconj`.


A compound lottery can be said to create a _mixture distribution_.

Our two ways of constructing a compound lottery will differ in their **timing**.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be out of the scope of this PR but we should only use bold for definitions

Suggested change
Our two ways of constructing a compound lottery will differ in their **timing**.
Our two ways of constructing a compound lottery will differ in their *timing*.


$$
\pi_t = E [ \textrm{nature chose distribution} f | w^t] , \quad t = 0, 1, 2, \ldots
\pi_t = E [ \textrm{nature chose distribution} f | w^t] , \quad t = 0, 1, 2, \ldots
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a space between $f$ and the text

Suggested change
\pi_t = E [ \textrm{nature chose distribution} f | w^t] , \quad t = 0, 1, 2, \ldots
\pi_t = E [ \textrm{nature chose distribution } f | w^t] , \quad t = 0, 1, 2, \ldots


See <https://numpy.org/doc/stable/reference/generated/numpy.searchsorted.html> for the
`searchsorted` function.
See the [numpy.searchsorted documentation](https://numpy.org/doc/stable/reference/generated/numpy.searchsorted.html) for details on the `searchsorted` function.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
See the [numpy.searchsorted documentation](https://numpy.org/doc/stable/reference/generated/numpy.searchsorted.html) for details on the `searchsorted` function.
See the [`numpy.searchsorted` documentation](https://numpy.org/doc/stable/reference/generated/numpy.searchsorted.html) for details on the `searchsorted` function.

@HumphreyYang HumphreyYang added review and removed ready labels Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[mix_model] FIX: links are full web links across the lecture

2 participants