New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows _attrs to be null IJupyterYDoc #21

Merged

davidbrochart merged 1 commit into QuantStack:main from brichet:allow_null_attr

Feb 6, 2025

Member

brichet commented Feb 6, 2025

See #20 (comment) for context.

The _attrs of JupyterYDoc could be undefined if comm_metadata.create_ydoc was falsy, but it was considered as defined.


          Allow _attrs to be null IJupyterYDoc

982f094

davidbrochart added the bug label

davidbrochart approved these changes

View reviewed changes

Member

davidbrochart left a comment

LGTM.

davidbrochart merged commit 2191225 into QuantStack:main

2 of 3 checks passed

brichet deleted the allow_null_attr branch

February 6, 2025 13:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug