Skip to content

Conversation

borchero
Copy link
Member

@borchero borchero commented Jul 9, 2025

Motivation

In a recent discussion, @MariusMerkleQC rightly pointed out that a data frame has a "primary key", regardless of how many columns the primary key spans. Using the plural might lead to some confusion.

Changes

  • Rename primary_keys to primary_key everywhere

Let's wait for this PR until we release v2.

@borchero borchero self-assigned this Jul 9, 2025
@borchero borchero added the v2 label Jul 9, 2025
@codecov
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (20c89f4) to head (4a85b0b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #85   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines         2901      2901           
=========================================
  Hits          2901      2901           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@borchero borchero added this to the v2 milestone Jul 15, 2025
@borchero borchero added refactor and removed v2 labels Jul 15, 2025
@borchero borchero merged commit ab5224b into main Oct 17, 2025
22 checks passed
@borchero borchero deleted the pk-singular branch October 17, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants