Bump dependency compat and try using TO on newer CUDA/cuTENSOR #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
lkdvos
reviewed
Sep 4, 2025
| Test = "1" | ||
| TupleTools = "1.6" | ||
| VectorInterface = "0.4.1,0.5" | ||
| cuTENSOR = "2.1.1" |
There was a problem hiding this comment.
I know it doesn't matter too much for this PR, but I think this minimal version was really required, mostly because we are relying on this PR : JuliaGPU/CUDA.jl#2356
|
That makes sense. I created this mostly as a test to see if this would
instantly break everything. Where is it that we’re relying on this specific
version? Is it in a downstream package?
…On Thu, Sep 4, 2025 at 12:56 PM Lukas Devos ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Project.toml
<#223 (comment)>
:
> @@ -49,7 +49,7 @@ StridedViews = "0.3, 0.4"
Test = "1"
TupleTools = "1.6"
VectorInterface = "0.4.1,0.5"
-cuTENSOR = "2.1.1"
I know it doesn't matter too much for this PR, but I think this minimal
version was really required, mostly because we are relying on this PR :
JuliaGPU/CUDA.jl#2356 <JuliaGPU/CUDA.jl#2356>
—
Reply to this email directly, view it on GitHub
<#223 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGKJY4TEDGVSTZRKYNGFXL3RALETAVCNFSM6AAAAACFTNUF2KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCOBUGU4DIMBTGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
No, the cuTENSOR.jl wrappers were restricted to |
|
Ah ok I see, I'll restore the minimum version then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This actually failed for me locally which is interesting/concerning. It would be great to support newer cuTENSOR and
CUDA.jlas a lot of updates have happened there.