Set NetVM and DispVM properly for StandaloneVMs #23
Conversation
|
pylint complains.. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025071903-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061004-4.3&flavor=update
Failed tests10 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/142375#dependencies 10 fixed
Unstable testsPerformance TestsPerformance degradation:9 performance degradations
Remaining performance tests:63 tests
|
|
Gah, I constantly forget that pylint is used here, since Qubes OS code doesn't use mypy, and all the projects I work on that use pylint also use mypy. |
ArrayBolt3
force-pushed
the
arraybolt3/standalone-netvm-fix
branch
from
c0dce5f to
c4fab43
Compare
|
Pylint now fixed, looking at the rtest failures now... (they look normal but still should be resolved) |
Previously, when creating a Whonix-Workstation standalone, the NetVM would be sys-firewall by default, and the default DispVM would be default-dvm. Both of these are wrong for most Whonix-Workstation qubes, so now when a qube has the whonix-ws feature set on it, it will automtically have its NetVM and DispVM changed to appropriate values for a Whonix-Workstation machine. This makes standalone creation work as expected.
ArrayBolt3
force-pushed
the
arraybolt3/standalone-netvm-fix
branch
from
c4fab43 to
f626949
Compare
|
@marmarek I can't find the repo containing the failing OpenQA tests (checked qubes-core-admin, openqa-tests-qubesos). |
|
See comment in the other PR |
| # look for appropriate whonix-gateway | ||
| if ( | ||
| template is not None | ||
| and 'whonix-default-gw' in template.features |
There was a problem hiding this comment.
Since all features are copied from template to standalone, theoretically for StandaloneVM you could look at vm.features. But in practice, the order in which they are copied is not deterministic, so it may not be copied at this stage yet :(
Since non-default name is rather rare case (and I doubt many users know about the whonix-default-gw feature - it's documented only in the README file here), it's probably not worth it to handle this case.
Previously, when creating a Whonix-Workstation standalone, the NetVM would be sys-firewall by default, and the default DispVM would be default-dvm. Both of these are wrong for most Whonix-Workstation qubes, so now when a qube has the whonix-ws feature set on it, it will automtically have its NetVM and DispVM changed to appropriate values for a Whonix-Workstation machine. This makes standalone creation work as expected.
Fixes QubesOS/qubes-issues#10067.