-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add custom-persist extension #650
base: main
Are you sure you want to change the base?
Conversation
@Guiiix Is there a companion PR to core-agent-linux? |
Hi @DemiMarie, yes this one: QubesOS/qubes-core-agent-linux#551 I'll fix lint errors today. |
68bcfbc
to
2d64eae
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #650 +/- ##
==========================================
+ Coverage 69.71% 69.82% +0.10%
==========================================
Files 58 59 +1
Lines 12499 12544 +45
==========================================
+ Hits 8714 8759 +45
Misses 3785 3785
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Please add some unit test |
1f0c3ec
to
929a076
Compare
929a076
to
7b1069a
Compare
Tests added |
I'll also add an integration test. In the meantime, can you update documentation at https://www.qubes-os.org/doc/bind-dirs/ to include this feature too? Or maybe you see some better place for that? |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025021317-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025020404-4.3&flavor=update
Failed tests86 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/127852#dependencies 30 fixed
Unstable testsPerformance TestsPerformance degradation:No issues Remaining performance tests:52 tests
|
custom-persist
extension (see QubesOS/qubes-issues#1006)Adds a custom-persist feature. The service custom-persist must be activated to enable the feature.
When the feature is enabled, user custom persistent file and dirs must be configured with
qvm-features
. Example:qvm-features work custom-persist.var_test /var/test