Skip to content

qubes-core-agent: remove conflict with firewalld #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2025

Conversation

3nprob
Copy link

@3nprob 3nprob commented Jun 19, 2025

Retrying #580 🤞

Currently, qubes-core-agent does not allow installation alongside firewalld. They seem to get along as fine as one would expect when allowed, though. Users should be allowed to use it if they want.

firewalld will not run even if the default systemd service is enabled: The service is actually enabled by presence of /var/run/qubes-service/firewalld.

3np added 2 commits June 19, 2025 01:04
- service enabled via /var/run/qubes-service/firewalld
- start after qubes-firewall for deterministic startup
@3nprob
Copy link
Author

3nprob commented Jun 19, 2025

Failing CI pipelines unrelated; gitlab infra issue

Fetching changes with git depth set to 50...
Initialized empty Git repository in /home/gitlab-runner/builds/QubesOS/qubes-core-agent-linux/.git/
Created fresh repository.
fatal: unable to access 'https://gitlab.com/QubesOS/qubes-core-agent-linux.git/': Failed to connect to gitlab.com port 443 after 135623 ms: Couldn't connect to server

Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.68%. Comparing base (46e2fc4) to head (bd9945f).
Report is 34 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #581   +/-   ##
=======================================
  Coverage   70.68%   70.68%           
=======================================
  Files           3        3           
  Lines         481      481           
=======================================
  Hits          340      340           
  Misses        141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qubesos-bot
Copy link

qubesos-bot commented Jun 21, 2025

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025062101-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061004-4.3&flavor=update

  • system_tests_dispvm

  • system_tests_qwt_win10@hw13

    • windows_install: Failed (test died)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...
  • system_tests_qwt_win10_seamless@hw13

    • windows_clipboard_and_filecopy: unnamed test (unknown)
    • windows_clipboard_and_filecopy: Failed (test died)
      # Test died: no candidate needle with tag(s) 'windows-Edge-address-...
  • system_tests_qwt_win11@hw13

    • windows_install: Failed (test died)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...
  • system_tests_audio@hw1

  • system_tests_guivm_vnc_gui_interactive

    • gui_filecopy: unnamed test (unknown)
    • gui_filecopy: Failed (test died)
      # Test died: no candidate needle with tag(s) 'disp-text-editor' mat...

Failed tests

15 failures
  • system_tests_extra

    • TC_00_QVCTest_whonix-workstation-17: test_010_screenshare (failure)
      AssertionError: 1 != 0 : Timeout waiting for /dev/video0 in test-in...
  • system_tests_dispvm

  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: qr/JmOTS-\d+-/...

    • gui_keyboard_layout: Failed (test died + timed out)
      # Test died: command 'echo -e '[Layout]...

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "# "...

  • system_tests_qwt_win10@hw13

    • windows_install: Failed (test died)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...
  • system_tests_qwt_win10_seamless@hw13

    • windows_clipboard_and_filecopy: unnamed test (unknown)
    • windows_clipboard_and_filecopy: Failed (test died)
      # Test died: no candidate needle with tag(s) 'windows-Edge-address-...
  • system_tests_qwt_win11@hw13

    • windows_install: Failed (test died)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...
  • system_tests_audio@hw1

  • system_tests_guivm_vnc_gui_interactive

    • gui_filecopy: unnamed test (unknown)
    • gui_filecopy: Failed (test died)
      # Test died: no candidate needle with tag(s) 'disp-text-editor' mat...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/142375#dependencies

10 fixed

Unstable tests

Performance Tests

Performance degradation:

8 performance degradations
  • whonix-gateway-17_socket: 8.69 🔺 ( previous job: 7.85, degradation: 110.61%)
  • whonix-workstation-17_exec-data-duplex-root: 98.59 🔺 ( previous job: 86.00, degradation: 114.63%)
  • dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 521.00 :small_red_triangle: ( previous job: 1091.00, degradation: 47.75%)
  • dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 2197.00 :small_red_triangle: ( previous job: 11086.00, degradation: 19.82%)
  • dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 21.00 :small_red_triangle: ( previous job: 1840.00, degradation: 1.14%)
  • dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 76287.00 :small_red_triangle: ( previous job: 122848.00, degradation: 62.10%)
  • dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 88510.00 :small_red_triangle: ( previous job: 167872.00, degradation: 52.72%)
  • dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 7446.00 :small_red_triangle: ( previous job: 8874.00, degradation: 83.91%)

Remaining performance tests:

64 tests
  • debian-12-xfce_exec: 5.40 🟢 ( previous job: 8.63, improvement: 62.63%)
  • debian-12-xfce_exec-root: 29.54 🔺 ( previous job: 29.44, degradation: 100.37%)
  • debian-12-xfce_socket: 8.56 🔺 ( previous job: 8.50, degradation: 100.67%)
  • debian-12-xfce_socket-root: 8.03 🟢 ( previous job: 8.31, improvement: 96.52%)
  • debian-12-xfce_exec-data-simplex: 65.85 🔺 ( previous job: 65.51, degradation: 100.51%)
  • debian-12-xfce_exec-data-duplex: 72.83 🟢 ( previous job: 73.55, improvement: 99.03%)
  • debian-12-xfce_exec-data-duplex-root: 72.30 🔺 ( previous job: 70.01, degradation: 103.26%)
  • debian-12-xfce_socket-data-duplex: 148.03 🟢 ( previous job: 161.35, improvement: 91.74%)
  • fedora-42-xfce_exec: 9.07
  • fedora-42-xfce_exec-root: 59.24
  • fedora-42-xfce_socket: 8.27
  • fedora-42-xfce_socket-root: 8.58
  • fedora-42-xfce_exec-data-simplex: 79.32
  • fedora-42-xfce_exec-data-duplex: 75.69
  • fedora-42-xfce_exec-data-duplex-root: 103.35
  • fedora-42-xfce_socket-data-duplex: 139.71
  • whonix-gateway-17_exec: 6.22 🟢 ( previous job: 7.34, improvement: 84.78%)
  • whonix-gateway-17_exec-root: 39.36 🟢 ( previous job: 39.57, improvement: 99.45%)
  • whonix-gateway-17_socket-root: 8.00 🔺 ( previous job: 7.89, degradation: 101.35%)
  • whonix-gateway-17_exec-data-simplex: 78.97 🔺 ( previous job: 77.76, degradation: 101.55%)
  • whonix-gateway-17_exec-data-duplex: 78.73 🔺 ( previous job: 78.39, degradation: 100.45%)
  • whonix-gateway-17_exec-data-duplex-root: 94.49 🔺 ( previous job: 90.74, degradation: 104.13%)
  • whonix-gateway-17_socket-data-duplex: 168.80 🔺 ( previous job: 161.95, degradation: 104.23%)
  • whonix-workstation-17_exec: 8.41 🔺 ( previous job: 8.27, degradation: 101.69%)
  • whonix-workstation-17_exec-root: 58.31 🔺 ( previous job: 57.61, degradation: 101.22%)
  • whonix-workstation-17_socket: 8.91 🟢 ( previous job: 8.97, improvement: 99.38%)
  • whonix-workstation-17_socket-root: 8.40 🟢 ( previous job: 9.46, improvement: 88.80%)
  • whonix-workstation-17_exec-data-simplex: 66.44 🟢 ( previous job: 74.54, improvement: 89.13%)
  • whonix-workstation-17_exec-data-duplex: 68.69 🟢 ( previous job: 74.84, improvement: 91.78%)
  • whonix-workstation-17_socket-data-duplex: 157.16 🟢 ( previous job: 160.20, improvement: 98.10%)
  • dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 478364.00 :green_circle: ( previous job: 289982.00, improvement: 164.96%)
  • dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 124985.00 :green_circle: ( previous job: 101988.00, improvement: 122.55%)
  • dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 120171.00 :green_circle: ( previous job: 14284.00, improvement: 841.30%)
  • dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 65006.00 :green_circle: ( previous job: 32696.00, improvement: 198.82%)
  • dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 16773.00 :small_red_triangle: ( previous job: 17102.00, degradation: 98.08%)
  • dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 332037.00 :green_circle: ( previous job: 289182.00, improvement: 114.82%)
  • dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 394943.00 :small_red_triangle: ( previous job: 433654.00, degradation: 91.07%)
  • dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 102194.00 :small_red_triangle: ( previous job: 108760.00, degradation: 93.96%)
  • dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 8331.00 :green_circle: ( previous job: 6356.00, improvement: 131.07%)
  • dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 4699.00 :green_circle: ( previous job: 4420.00, improvement: 106.31%)
  • fedora-42-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 382971.00
  • fedora-42-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 151388.00
  • fedora-42-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 313381.00
  • fedora-42-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 36955.00
  • fedora-42-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 89829.00
  • fedora-42-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 2402.00
  • fedora-42-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8379.00
  • fedora-42-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 858.00
  • fedora-42-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 345153.00
  • fedora-42-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 154608.00
  • fedora-42-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 328604.00
  • fedora-42-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 46472.00
  • fedora-42-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 93043.00
  • fedora-42-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 4779.00
  • fedora-42-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 8992.00
  • fedora-42-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 337.00
  • fedora-42-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 346293.00
  • fedora-42-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 136927.00
  • fedora-42-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 233952.00
  • fedora-42-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 75276.00
  • fedora-42-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 84438.00
  • fedora-42-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 4699.00
  • fedora-42-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 7891.00
  • fedora-42-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 912.00

@marmarek marmarek merged commit d8d5a6a into QubesOS:main Jun 21, 2025
3 of 5 checks passed
@3nprob
Copy link
Author

3nprob commented Jun 21, 2025

Thanks for quick review and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants