-
-
Notifications
You must be signed in to change notification settings - Fork 121
qubes-core-agent: remove conflict with firewalld #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- service enabled via /var/run/qubes-service/firewalld - start after qubes-firewall for deterministic startup
Failing CI pipelines unrelated; gitlab infra issue
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #581 +/- ##
=======================================
Coverage 70.68% 70.68%
=======================================
Files 3 3
Lines 481 481
=======================================
Hits 340 340
Misses 141 141 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025062101-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061004-4.3&flavor=update
Failed tests15 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/142375#dependencies 10 fixed
Unstable testsPerformance TestsPerformance degradation:8 performance degradations
Remaining performance tests:64 tests
|
Thanks for quick review and merge! |
Retrying #580 🤞
Currently, qubes-core-agent does not allow installation alongside firewalld. They seem to get along as fine as one would expect when allowed, though. Users should be allowed to use it if they want.
firewalld will not run even if the default systemd service is enabled: The service is actually enabled by presence of
/var/run/qubes-service/firewalld
.