Skip to content

Optimize SVG icons #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Optimize SVG icons #265

wants to merge 1 commit into from

Conversation

zpc0
Copy link

@zpc0 zpc0 commented Jun 5, 2025

using SVGO with --pretty option.

Copy link

codecov bot commented Jun 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.98%. Comparing base (70de337) to head (73d25af).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
- Coverage   93.00%   92.98%   -0.02%     
==========================================
  Files          64       64              
  Lines       13217    13217              
==========================================
- Hits        12292    12290       -2     
- Misses        925      927       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qubesos-bot
Copy link

qubesos-bot commented Jul 5, 2025

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025080103-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061004-4.3&flavor=update

  • system_tests_network_updates

    • TC_00_Dom0Upgrade_whonix-gateway-17: test_001_update_check (failure)
      ^... AssertionError: '' is not true
  • system_tests_dispvm

  • system_tests_basic_vm_qrexec_gui_zfs

  • system_tests_audio

  • system_tests_audio@hw1

  • system_tests_qwt_win10@hw13

    • windows_install: wait_serial (wait serial expected)
      # wait_serial expected: qr/tKcyh-\d+-/...

    • windows_install: Failed (test died + timed out)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

  • system_tests_qwt_win10_seamless@hw13

    • windows_install: wait_serial (wait serial expected)
      # wait_serial expected: qr/4E4Ei-\d+-/...

    • windows_install: Failed (test died + timed out)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

  • system_tests_qwt_win11@hw13

    • windows_install: wait_serial (wait serial expected)
      # wait_serial expected: qr/qDqV_-\d+-/...

    • windows_install: Failed (test died + timed out)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

  • system_tests_dispvm_perf@hw7

Failed tests

44 failures
  • system_tests_network_updates

    • TC_00_Dom0Upgrade_whonix-gateway-17: test_001_update_check (failure)
      ^... AssertionError: '' is not true
  • system_tests_dispvm

  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

    • gui_keyboard_layout: Failed (test died)
      # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

  • system_tests_basic_vm_qrexec_gui_zfs

  • system_tests_audio

  • system_tests_audio@hw1

  • system_tests_qwt_win10@hw13

    • windows_install: wait_serial (wait serial expected)
      # wait_serial expected: qr/tKcyh-\d+-/...

    • windows_install: Failed (test died + timed out)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

  • system_tests_qwt_win10_seamless@hw13

    • windows_install: wait_serial (wait serial expected)
      # wait_serial expected: qr/4E4Ei-\d+-/...

    • windows_install: Failed (test died + timed out)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

  • system_tests_qwt_win11@hw13

    • windows_install: wait_serial (wait serial expected)
      # wait_serial expected: qr/qDqV_-\d+-/...

    • windows_install: Failed (test died + timed out)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

  • system_tests_dispvm_perf@hw7

  • system_tests_extra

    • TC_00_QVCTest_whonix-workstation-17: test_010_screenshare (failure)
      AssertionError: 1 != 0 : Timeout waiting for /dev/video0 in test-in...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/142375#dependencies

10 fixed

Unstable tests

Performance Tests

Performance degradation:

7 performance degradations
  • whonix-workstation-17_exec-data-duplex-root: 97.45 🔺 ( previous job: 86.00, degradation: 113.32%)
  • dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 7905.00 :small_red_triangle: ( previous job: 11086.00, degradation: 71.31%)
  • dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 251.00 :small_red_triangle: ( previous job: 1840.00, degradation: 13.64%)
  • dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 104701.00 :small_red_triangle: ( previous job: 433654.00, degradation: 24.14%)
  • dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 138113.00 :small_red_triangle: ( previous job: 167872.00, degradation: 82.27%)
  • dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 34361.00 :small_red_triangle: ( previous job: 108760.00, degradation: 31.59%)
  • dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 6655.00 :small_red_triangle: ( previous job: 8874.00, degradation: 74.99%)

Remaining performance tests:

166 tests
  • debian-12-xfce_exec: 7.31 🟢 ( previous job: 8.63, improvement: 84.70%)
  • debian-12-xfce_exec-root: 27.94 🟢 ( previous job: 29.44, improvement: 94.93%)
  • debian-12-xfce_socket: 8.53 🔺 ( previous job: 8.50, degradation: 100.34%)
  • debian-12-xfce_socket-root: 8.23 🟢 ( previous job: 8.31, improvement: 98.95%)
  • debian-12-xfce_exec-data-simplex: 63.09 🟢 ( previous job: 65.51, improvement: 96.31%)
  • debian-12-xfce_exec-data-duplex: 74.45 🔺 ( previous job: 73.55, degradation: 101.24%)
  • debian-12-xfce_exec-data-duplex-root: 70.89 🔺 ( previous job: 70.01, degradation: 101.26%)
  • debian-12-xfce_socket-data-duplex: 163.49 🔺 ( previous job: 161.35, degradation: 101.33%)
  • fedora-42-xfce_exec: 9.25
  • fedora-42-xfce_exec-root: 57.74
  • fedora-42-xfce_socket: 8.11
  • fedora-42-xfce_socket-root: 7.87
  • fedora-42-xfce_exec-data-simplex: 76.17
  • fedora-42-xfce_exec-data-duplex: 72.48
  • fedora-42-xfce_exec-data-duplex-root: 96.48
  • fedora-42-xfce_socket-data-duplex: 152.96
  • whonix-gateway-17_exec: 7.05 🟢 ( previous job: 7.34, improvement: 96.04%)
  • whonix-gateway-17_exec-root: 39.24 🟢 ( previous job: 39.57, improvement: 99.15%)
  • whonix-gateway-17_socket: 7.69 🟢 ( previous job: 7.85, improvement: 97.87%)
  • whonix-gateway-17_socket-root: 8.03 🔺 ( previous job: 7.89, degradation: 101.75%)
  • whonix-gateway-17_exec-data-simplex: 79.64 🔺 ( previous job: 77.76, degradation: 102.42%)
  • whonix-gateway-17_exec-data-duplex: 79.24 🔺 ( previous job: 78.39, degradation: 101.09%)
  • whonix-gateway-17_exec-data-duplex-root: 87.56 🟢 ( previous job: 90.74, improvement: 96.49%)
  • whonix-gateway-17_socket-data-duplex: 167.05 🔺 ( previous job: 161.95, degradation: 103.15%)
  • whonix-workstation-17_exec: 7.69 🟢 ( previous job: 8.27, improvement: 92.89%)
  • whonix-workstation-17_exec-root: 54.50 🟢 ( previous job: 57.61, improvement: 94.61%)
  • whonix-workstation-17_socket: 7.94 🟢 ( previous job: 8.97, improvement: 88.54%)
  • whonix-workstation-17_socket-root: 8.39 🟢 ( previous job: 9.46, improvement: 88.67%)
  • whonix-workstation-17_exec-data-simplex: 73.27 🟢 ( previous job: 74.54, improvement: 98.31%)
  • whonix-workstation-17_exec-data-duplex: 78.22 🔺 ( previous job: 74.84, degradation: 104.52%)
  • whonix-workstation-17_socket-data-duplex: 143.75 🟢 ( previous job: 160.20, improvement: 89.73%)
  • dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 306601.00 :green_circle: ( previous job: 289982.00, improvement: 105.73%)
  • dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 150851.00 :green_circle: ( previous job: 101988.00, improvement: 147.91%)
  • dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 153681.00 :green_circle: ( previous job: 14284.00, improvement: 1075.90%)
  • dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 46672.00 :green_circle: ( previous job: 32696.00, improvement: 142.75%)
  • dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 96059.00 :green_circle: ( previous job: 17102.00, improvement: 561.68%)
  • dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 7341.00 :green_circle: ( previous job: 1091.00, improvement: 672.87%)
  • dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 272853.00 :small_red_triangle: ( previous job: 289182.00, degradation: 94.35%)
  • dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 246549.00 :green_circle: ( previous job: 122848.00, improvement: 200.69%)
  • dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 7641.00 :green_circle: ( previous job: 6356.00, improvement: 120.22%)
  • dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 4304.00 :small_red_triangle: ( previous job: 4420.00, degradation: 97.38%)
  • fedora-42-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 401753.00
  • fedora-42-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 147561.00
  • fedora-42-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 321058.00
  • fedora-42-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 50510.00
  • fedora-42-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 93305.00
  • fedora-42-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 3335.00
  • fedora-42-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 7478.00
  • fedora-42-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 787.00
  • fedora-42-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 370129.00
  • fedora-42-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 183654.00
  • fedora-42-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 341555.00
  • fedora-42-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 67653.00
  • fedora-42-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 72189.00
  • fedora-42-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 3002.00
  • fedora-42-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 7724.00
  • fedora-42-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 1014.00
  • fedora-42-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 362703.00
  • fedora-42-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 137201.00
  • fedora-42-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 310965.00
  • fedora-42-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 57762.00
  • fedora-42-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 87093.00
  • fedora-42-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 2700.00
  • fedora-42-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 8703.00
  • fedora-42-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 395.00
  • debian-12-xfce_dispvm(avg:6.313): 101.01
  • debian-12-xfce_dispvm-gui(avg:7.011): 112.18
  • debian-12-xfce_dispvm-concurrent(avg:3.340): 53.44
  • debian-12-xfce_dispvm-gui-concurrent(avg:4.006): 64.09
  • debian-12-xfce_dispvm-dom0(avg:6.835): 109.35
  • debian-12-xfce_dispvm-dom0-gui(avg:7.573): 121.17
  • debian-12-xfce_dispvm-dom0-concurrent(avg:3.502): 56.03
  • debian-12-xfce_dispvm-dom0-gui-concurrent(avg:4.211): 67.38
  • debian-12-xfce_dispvm-preload(avg:3.527): 56.44
  • debian-12-xfce_dispvm-preload-gui(avg:4.125): 65.99
  • debian-12-xfce_dispvm-preload-concurrent(avg:2.744): 43.90
  • debian-12-xfce_dispvm-preload-gui-concurrent(avg:3.240): 51.84
  • debian-12-xfce_dispvm-preload-dom0(avg:3.752): 60.04
  • debian-12-xfce_dispvm-preload-dom0-concurrent(avg:2.938): 47.00
  • debian-12-xfce_dispvm-preload-dom0-gui-concurrent(avg:3.710): 59.36
  • debian-12-xfce_dispvm-api(avg:6.737): 107.80
  • debian-12-xfce_dispvm-gui-api(avg:7.801): 124.81
  • debian-12-xfce_dispvm-concurrent-api(avg:3.285): 52.56
  • debian-12-xfce_dispvm-gui-concurrent-api(avg:3.812): 60.99
  • debian-12-xfce_dispvm-preload-api(avg:3.634): 58.14
  • debian-12-xfce_dispvm-preload-less-api(avg:6.124): 97.99
  • debian-12-xfce_dispvm-preload-more-api(avg:3.688): 59.02
  • debian-12-xfce_dispvm-preload-gui-api(avg:5.045): 80.71
  • debian-12-xfce_dispvm-preload-concurrent-api(avg:3.060): 48.96
  • debian-12-xfce_dispvm-preload-gui-concurrent-api(avg:3.900): 62.40
  • debian-12-xfce_vm(avg:0.408): 6.53
  • debian-12-xfce_vm-gui(avg:0.484): 7.74
  • debian-12-xfce_vm-api(avg:0.093): 1.49
  • debian-12-xfce_vm-gui-api(avg:0.119): 1.91
  • debian-12-xfce_vm-concurrent-api(avg:0.047): 0.75
  • debian-12-xfce_vm-gui-concurrent-api(avg:0.115): 1.83
  • fedora-42-xfce_dispvm(avg:7.084): 113.34
  • fedora-42-xfce_dispvm-gui(avg:8.384): 134.15
  • fedora-42-xfce_dispvm-concurrent(avg:4.160): 66.56
  • fedora-42-xfce_dispvm-gui-concurrent(avg:5.041): 80.65
  • fedora-42-xfce_dispvm-dom0(avg:7.847): 125.56
  • fedora-42-xfce_dispvm-dom0-gui(avg:8.902): 142.43
  • fedora-42-xfce_dispvm-dom0-concurrent(avg:4.427): 70.83
  • fedora-42-xfce_dispvm-dom0-gui-concurrent(avg:5.161): 82.58
  • fedora-42-xfce_dispvm-preload(avg:4.362): 69.79
  • fedora-42-xfce_dispvm-preload-gui(avg:4.903): 78.45
  • fedora-42-xfce_dispvm-preload-concurrent(avg:3.129): 50.07
  • fedora-42-xfce_dispvm-preload-gui-concurrent(avg:4.073): 65.17
  • fedora-42-xfce_dispvm-preload-dom0(avg:4.498): 71.96
  • fedora-42-xfce_dispvm-preload-dom0-gui(avg:5.649): 90.38
  • fedora-42-xfce_dispvm-preload-dom0-concurrent(avg:3.541): 56.66
  • fedora-42-xfce_dispvm-preload-dom0-gui-concurrent(avg:4.301): 68.81
  • fedora-42-xfce_dispvm-api(avg:7.906): 126.49
  • fedora-42-xfce_dispvm-gui-api(avg:9.207): 147.32
  • fedora-42-xfce_dispvm-concurrent-api(avg:3.903): 62.44
  • fedora-42-xfce_dispvm-preload-api(avg:4.405): 70.48
  • fedora-42-xfce_dispvm-preload-less-api(avg:7.072): 113.16
  • fedora-42-xfce_dispvm-preload-more-api(avg:4.274): 68.38
  • fedora-42-xfce_dispvm-preload-gui-api(avg:5.601): 89.62
  • fedora-42-xfce_dispvm-preload-concurrent-api(avg:3.857): 61.72
  • fedora-42-xfce_dispvm-preload-gui-concurrent-api(avg:4.564): 73.02
  • fedora-42-xfce_vm(avg:0.561): 8.98
  • fedora-42-xfce_vm-gui(avg:0.569): 9.11
  • fedora-42-xfce_vm-api(avg:0.140): 2.23
  • fedora-42-xfce_vm-gui-api(avg:0.149): 2.38
  • fedora-42-xfce_vm-concurrent-api(avg:0.082): 1.32
  • fedora-42-xfce_vm-gui-concurrent-api(avg:0.137): 2.19
  • whonix-gateway-17_dispvm-gui-concurrent(avg:4.853): 77.65
  • whonix-gateway-17_dispvm-dom0-gui(avg:8.976): 143.62
  • whonix-gateway-17_dispvm-dom0-gui-concurrent(avg:5.223): 83.58
  • whonix-gateway-17_dispvm-gui-concurrent-api(avg:4.657): 74.52
  • whonix-gateway-17_vm-gui(avg:0.560): 8.97
  • whonix-gateway-17_vm-gui-api(avg:0.134): 2.14
  • whonix-gateway-17_vm-gui-concurrent-api(avg:0.119): 1.91
  • whonix-workstation-17_dispvm(avg:7.929): 126.86
  • whonix-workstation-17_dispvm-gui(avg:8.851): 141.62
  • whonix-workstation-17_dispvm-concurrent(avg:4.709): 75.35
  • whonix-workstation-17_dispvm-gui-concurrent(avg:5.524): 88.39
  • whonix-workstation-17_dispvm-dom0(avg:8.600): 137.60
  • whonix-workstation-17_dispvm-dom0-gui(avg:9.760): 156.17
  • whonix-workstation-17_dispvm-dom0-concurrent(avg:4.895): 78.32
  • whonix-workstation-17_dispvm-dom0-gui-concurrent(avg:5.742): 91.87
  • whonix-workstation-17_dispvm-preload(avg:7.621): 121.94
  • whonix-workstation-17_dispvm-preload-gui(avg:8.519): 136.31
  • whonix-workstation-17_dispvm-preload-concurrent(avg:4.496): 71.93
  • whonix-workstation-17_dispvm-preload-gui-concurrent(avg:5.009): 80.14
  • whonix-workstation-17_dispvm-preload-dom0(avg:5.076): 81.22
  • whonix-workstation-17_dispvm-preload-dom0-gui(avg:6.605): 105.68
  • whonix-workstation-17_dispvm-preload-dom0-concurrent(avg:4.149): 66.39
  • whonix-workstation-17_dispvm-preload-dom0-gui-concurrent(avg:5.284): 84.54
  • whonix-workstation-17_dispvm-api(avg:8.622): 137.96
  • whonix-workstation-17_dispvm-gui-api(avg:9.810): 156.96
  • whonix-workstation-17_dispvm-concurrent-api(avg:4.354): 69.67
  • whonix-workstation-17_dispvm-gui-concurrent-api(avg:5.317): 85.08
  • whonix-workstation-17_dispvm-preload-api(avg:5.195): 83.13
  • whonix-workstation-17_dispvm-preload-less-api(avg:7.979): 127.67
  • whonix-workstation-17_dispvm-preload-more-api(avg:5.196): 83.14
  • whonix-workstation-17_dispvm-preload-gui-api(avg:6.493): 103.89
  • whonix-workstation-17_dispvm-preload-concurrent-api(avg:4.252): 68.04
  • whonix-workstation-17_dispvm-preload-gui-concurrent-api(avg:5.189): 83.03
  • whonix-workstation-17_vm(avg:0.585): 9.36
  • whonix-workstation-17_vm-gui(avg:0.578): 9.24
  • whonix-workstation-17_vm-api(avg:0.152): 2.43
  • whonix-workstation-17_vm-gui-api(avg:0.149): 2.38
  • whonix-workstation-17_vm-concurrent-api(avg:0.112): 1.79
  • whonix-workstation-17_vm-gui-concurrent-api(avg:0.146): 2.34

@marmarek
Copy link
Member

marmarek commented Jul 5, 2025

"updates" icon looks a bit bigger in the global config: https://openqa.qubes-os.org/tests/145744#step/desktop_linux_manager_config/8 . Is it okay? It's hard to say for me if it's now bigger than others, or was it smaller before...

@marmarta
Copy link
Member

marmarta commented Jul 7, 2025

"updates" icon looks a bit bigger in the global config: https://openqa.qubes-os.org/tests/145744#step/desktop_linux_manager_config/8 . Is it okay? It's hard to say for me if it's now bigger than others, or was it smaller before...

....SVG renderer blues... I am not sure tbh, and this makes me worried. I think it got slightly bigger?

@zpc0
Copy link
Author

zpc0 commented Jul 14, 2025

"updates" icon looks a bit bigger in the global config: https://openqa.qubes-os.org/tests/145744#step/desktop_linux_manager_config/8 . Is it okay? It's hard to say for me if it's now bigger than others, or was it smaller before...

I checked both old and new SVGs by converting SVG to PNG using ImageMagick, and they are same size (40px). So this maybe GTK's rendering bug...
I'm fine with reverting affected SVG files.

SVGO with --pretty --multipass option and
removeMetadata: false
cleanupIds: false
removeViewBox: false
@zpc0 zpc0 force-pushed the optimize-icons branch from ab7e746 to 73d25af Compare July 31, 2025 08:23
@zpc0
Copy link
Author

zpc0 commented Jul 31, 2025

Update:

  • Revert qui-updates*.svg to original.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants