-
-
Notifications
You must be signed in to change notification settings - Fork 43
Optimize SVG icons #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Optimize SVG icons #265
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
==========================================
- Coverage 93.00% 92.98% -0.02%
==========================================
Files 64 64
Lines 13217 13217
==========================================
- Hits 12292 12290 -2
- Misses 925 927 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025080103-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061004-4.3&flavor=update
Failed tests44 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/142375#dependencies 10 fixed
Unstable testsPerformance TestsPerformance degradation:7 performance degradations
Remaining performance tests:166 tests
|
"updates" icon looks a bit bigger in the global config: https://openqa.qubes-os.org/tests/145744#step/desktop_linux_manager_config/8 . Is it okay? It's hard to say for me if it's now bigger than others, or was it smaller before... |
....SVG renderer blues... I am not sure tbh, and this makes me worried. I think it got slightly bigger? |
I checked both old and new SVGs by converting SVG to PNG using ImageMagick, and they are same size (40px). So this maybe GTK's rendering bug... |
SVGO with --pretty --multipass option and removeMetadata: false cleanupIds: false removeViewBox: false
Update:
|
using SVGO with --pretty option.