Send icons for legacy X11 Apps #231
Conversation
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025060912-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031804-4.3&flavor=update
Failed tests38 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/132953#dependencies 14 fixed
Unstable testsPerformance TestsPerformance degradation:14 performance degradations
Remaining performance tests:58 tests
|
Since very old X11 Apps (Xterm, Xcalc, Xlogo, Xclock, Xeyes, ...) do not have the `_NET_WM_ICON` Atom, revert to `WM_HINT` and extract icons and their transparency with that technology. This is mostly useful for Xterm fixes: QubesOS/qubes-issues#9973
|
Reason for amendment: While I could not find any program which uses 8bit/pixel pixel_mask (on Qubes OS 4.3 & Xfwm), It would be better to write the code for the hypothetical scenario and be safe than sorry. |
window-icon-updater/icon-sender
Outdated
| except ( | ||
| xcffib.xproto.WindowError, | ||
| xcffib.xproto.AccessError, | ||
| NoIconError |
There was a problem hiding this comment.
You don't need to catch NoIconError if you're going to transform it into the same exception.
There was a problem hiding this comment.
A changed this a little bit, catching another error (xproto.WindowError).
|
@marmarek The openQA test does not show the 2nd commit of this PR. |
Since xcffib is preferred over Xlib and the method for `_NET_WM_ICON` is already implemented via xcffib, rewrite the previous patch with xcffib related: QubesOS/qubes-issues#9973
Since very old X11 Apps (Xterm, Xcalc, Xlogo, Xclock, Xeyes, ...) do not have the
_NET_WM_ICONAtom, revert toWM_HINTand extract icons and their transparency with that technology. This is mostly useful for Xtermfixes: QubesOS/qubes-issues#9973