Support arbitrary notification daemons #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DemiMarie
force-pushed
the
any-notification-daemon
branch
2 times, most recently
from
ef0b5dd to
829b792
Compare
marmarek
reviewed
Sep 28, 2024
DemiMarie
force-pushed
the
any-notification-daemon
branch
2 times, most recently
from
eefa4fc to
c32813f
Compare
marmarek
requested changes
Sep 30, 2024
| @@ -52,6 +52,7 @@ Requires: fwupd-qubes-vm | |||
| %if ! (0%{?rhel} && 0%{?rhel} <= 8) | |||
| Requires: qubes-pdf-converter | |||
| %endif | |||
| Recommends: (xfce4-notifyd or desktop-notification-daemon) | |||
There was a problem hiding this comment.
and hope the first one will be preferred if not installed already
So, this doesn't work. Installing this package when no notification daemon is installed yet pulls in dunst (at least in my test, it could be also non-deterministic...). So, if you have no better ideas, it's probably best to go back to the initial version (and at a later time switch to the qubes-notification-agent).
There was a problem hiding this comment.
Does that mean that this PR should be closed?
There was a problem hiding this comment.
No, revert to its initial shape (Recommends: xfce4-notifyd)
Qubes OS only recomments that _a_ notification daemon be present, not that specifically xfce4-notifyd is present. Having multiple notification daemons installed leads to problems. Instead, require the desktop-notification-daemon capability, which is provided by multiple notification daemons. This allows using an alternate notification daemon, such as a Qubes-specific one currently in development. Fixes: QubesOS/qubes-issues#8729
DemiMarie
force-pushed
the
any-notification-daemon
branch
from
c32813f to
e679468
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qubes OS only recomments that a notification daemon be present, not that specifically xfce4-notifyd is present. Having multiple notification daemons installed leads to problems. Instead, require the desktop-notification-daemon capability, which is provided by multiple notification daemons. This allows using an alternate notification daemon, such as a Qubes-specific one currently in development.
Fixes: QubesOS/qubes-issues#8729