fix(ci): atomic publish workflow + SDK test fix#23
Merged
henrypalacios merged 1 commit intomainfrom Apr 17, 2026
Merged
Conversation
b45d95a to
a61565b
Compare
Restructure publish workflows: bump version locally → build → publish → commit only after successful publish. Prevents version drift when publish fails (was bumping+committing before publish). Also: - Fix describe.only in SDK fraction test (blocked CI) - Add repository field to both package.json (required for provenance) - Remove upload-artifact (no longer consumed by publish job) - Replace always() with !cancelled()
a61565b to
7877025
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Atomic publish (prevents version drift)
Restructure both publish workflows so version bump only commits to repo AFTER successful npm publish:
Other fixes
describe.onlyintest/fraction.test.ts(was blocking SDK publish)repositoryfield (object format) to SDKpackage.jsonfor provenanceupload-artifactstep (publish job builds from source)always()with!cancelled()in publish-npm conditionTest plan