Skip to content

fix(ci): atomic publish workflow + SDK test fix#23

Merged
henrypalacios merged 1 commit intomainfrom
fix/add-repository-field
Apr 17, 2026
Merged

fix(ci): atomic publish workflow + SDK test fix#23
henrypalacios merged 1 commit intomainfrom
fix/add-repository-field

Conversation

@henrypalacios
Copy link
Copy Markdown
Collaborator

Summary

Atomic publish (prevents version drift)

Restructure both publish workflows so version bump only commits to repo AFTER successful npm publish:

Before (broken):          After (atomic):
bump → commit → publish   bump (local) → build → publish → commit
       ↑ if publish fails,        ↑ if publish fails,
         version is already        nothing changes in repo
         bumped in repo

Other fixes

  • Remove describe.only in test/fraction.test.ts (was blocking SDK publish)
  • Add repository field (object format) to SDK package.json for provenance
  • Remove unused upload-artifact step (publish job builds from source)
  • Replace always() with !cancelled() in publish-npm condition

Test plan

  • Protocol-core publish workflow succeeds end-to-end
  • SDK publish workflow succeeds end-to-end
  • If publish fails, version is NOT bumped in repo

@henrypalacios henrypalacios force-pushed the fix/add-repository-field branch from b45d95a to a61565b Compare April 17, 2026 02:14
Restructure publish workflows: bump version locally → build → publish
→ commit only after successful publish. Prevents version drift when
publish fails (was bumping+committing before publish).

Also:
- Fix describe.only in SDK fraction test (blocked CI)
- Add repository field to both package.json (required for provenance)
- Remove upload-artifact (no longer consumed by publish job)
- Replace always() with !cancelled()
@henrypalacios henrypalacios force-pushed the fix/add-repository-field branch from a61565b to 7877025 Compare April 17, 2026 02:28
@henrypalacios henrypalacios merged commit 200c7ed into main Apr 17, 2026
2 checks passed
@henrypalacios henrypalacios deleted the fix/add-repository-field branch April 17, 2026 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant