fix(ci): push tags explicitly for GitHub Release creation#24
Merged
henrypalacios merged 1 commit intomainfrom Apr 17, 2026
Merged
fix(ci): push tags explicitly for GitHub Release creation#24henrypalacios merged 1 commit intomainfrom
henrypalacios merged 1 commit intomainfrom
Conversation
Tags with slashes (protocol-core/v0.1.1) are not pushed by git push --follow-tags. Push branch and tag separately to ensure the tag exists on remote before gh release create runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
git push --follow-tagswith explicit tag push. Tags with slashes (protocol-core/v0.1.1) are not pushed by--follow-tags, causinggh release createto fail with "tag exists locally but has not been pushed".Root cause
git push --follow-tagsonly pushes tags that are reachable from the pushed refs AND are annotated. Our tags are lightweight and contain/, which--follow-tagsdoesn't handle reliably.Test plan