Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dono fb #8

Closed
wants to merge 23 commits into from
Closed

Dono fb #8

wants to merge 23 commits into from

Conversation

dceu
Copy link
Collaborator

@dceu dceu commented Mar 6, 2024

Please try and run 'yarn install' / 'npm install' and 'npx expo start' from the existing dev branch first. Then the same with the dono-fb branch.

This merge includes:

  • Feature: loading a quiz from firebase during the game countdown.
  • Fix: dev branch loads the question from sampleQuiz instead of firebase (this was an oversight during the main -> dev merge).
  • Code for loading a quiz generated through the PixieBrix flow and Firebase functions flow.
  • Fix: Loading the expected answer per question on the score page.

@mcatcruz
Copy link
Collaborator

Thanks for your patience, Donovan! I have finished reviewing the code and I am grateful for the descriptive variable names and commit messages, as well as for the code being straightforward. I appreciate your and Annalisa's work on Firebase, PixieBrix, and even Gemini implementation! Other than code cleanup, my only other suggestion is to in CountDownPage.js:

  • Since doOnce ensures the quiz is loaded only once when the component mounts, using [] as the dependency array would have the same effect.

That's it. Thanks again and happy coding!

@Annalisa-Boerner
Copy link
Collaborator

Thanks for your patience with me, as well! LGTM. Loved both the clear commit messages and the summary.

@dceu
Copy link
Collaborator Author

dceu commented Mar 27, 2024

I figured out why only a blank page is loading from the dist folder:

The global.css is looking for fonts in assets/fonts, which is correct and is found when we run npx expo start.

But after it bundles for the web dist, expo puts fonts in dist/assets/assets/fonts/ while the global css is looking for './assets/fonts/' while living in '/dist/_expo/static/css'

Going to merge up to the ci/cd and then create a new branch from here for working on ci/cd.

@dceu dceu closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants