-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dono fb #8
Conversation
…on.correct_answer
Dev pull into current working
… const date = todayFormatted to get today's quiz
Thanks for your patience, Donovan! I have finished reviewing the code and I am grateful for the descriptive variable names and commit messages, as well as for the code being straightforward. I appreciate your and Annalisa's work on Firebase, PixieBrix, and even Gemini implementation! Other than code cleanup, my only other suggestion is to in CountDownPage.js:
That's it. Thanks again and happy coding! |
Thanks for your patience with me, as well! LGTM. Loved both the clear commit messages and the summary. |
Create main.yml -- testing deployment using actions
I figured out why only a blank page is loading from the dist folder: The global.css is looking for fonts in assets/fonts, which is correct and is found when we run npx expo start. But after it bundles for the web dist, expo puts fonts in dist/assets/assets/fonts/ while the global css is looking for './assets/fonts/' while living in '/dist/_expo/static/css' Going to merge up to the ci/cd and then create a new branch from here for working on ci/cd. |
Please try and run 'yarn install' / 'npm install' and 'npx expo start' from the existing dev branch first. Then the same with the dono-fb branch.
This merge includes: