fix: resolve iOS voting popup comment input focus issue#307
Open
cmateos91 wants to merge 1 commit into
Open
Conversation
The mousedown preventDefault on the #popButtons container was blocking iOS Safari from focusing the comment input field. Now excludes input/textarea elements from preventDefault, adds programmatic focus via useRef when the comment panel opens, and increases input height by 25% for better mobile tap-target accessibility. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
✅ Deploy Preview for quotevote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Thank you @cmateos91 for your great work! @Om7035 will review and provide feedback or merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #114 — On iOS mobile, the comment input inside the voting popup did not reliably accept focus when tapped.
mousedownevent handler on#popButtonscallede.preventDefault()unconditionally, which blocks iOS Safari's focus chain (iOS synthesizesmousedownfrom touch events)preventDefaultwhen the target is aninputortextareaelement, so native focus behavior works correctly on iOSuseRef+useEffectto programmatically focus the input when the comment panel opens (after the Zoom animation completes)minHeightto50pxand setfontSize: 1rem(~25% larger) for better mobile accessibilityAcceptance Criteria
Test plan
🤖 Generated with Claude Code