fix(getUserFollowInfo): replace isUndefined with null-safe check for missing user#324
Open
Anton-dev3306 wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for quotevote canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in
getUserFollowInfo.jswhere the existence check for a user was usingisUndefined(userData)from lodash.UserModel.findOne()returnsnullwhen no document is found, notundefined. SinceisUndefined(null)evaluates tofalse, the guard never triggered, causing the function to attempt accessinguserData._followingIdon anullobject and throwing:Changes
isUndefined(userData)with!userData: Correctly handles bothnullandundefinedreturn values from Mongoose.isUndefinedimport from lodash: The import is no longer needed after the fix.Verification
getUserFollowInfowith a non-existent username now returns{ error: true, message: 'No user found' }instead of throwing a TypeError.Related Issue
Fixes #323