Skip to content

Revert "fix(railway): add .npmrc with legacy-peer-deps to fix Nixpacks build conflict"#332

Open
Om7035 wants to merge 1 commit into
mainfrom
revert-331-fix/add-npmrc-legacy-peer-deps
Open

Revert "fix(railway): add .npmrc with legacy-peer-deps to fix Nixpacks build conflict"#332
Om7035 wants to merge 1 commit into
mainfrom
revert-331-fix/add-npmrc-legacy-peer-deps

Conversation

@Om7035
Copy link
Copy Markdown
Collaborator

@Om7035 Om7035 commented May 10, 2026

Reverts #331

@railway-app
Copy link
Copy Markdown

railway-app Bot commented May 10, 2026

This PR was not deployed automatically as @Om7035 does not have access to the Railway project.

In order to get automatic PR deploys, please add @Om7035 to your workspace on Railway.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 10, 2026

Deploy Preview for quotevote canceled.

Name Link
🔨 Latest commit bf7cc63
🔍 Latest deploy log https://app.netlify.com/projects/quotevote/deploys/6a00cfbd75268a0008334f55

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bf7cc6385d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .npmrc
@@ -1 +0,0 @@
legacy-peer-deps=true No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep project-level legacy-peer-deps configuration

Deleting this root .npmrc removes the default legacy-peer-deps=true behavior for every plain npm install in the monorepo. npm’s config docs explicitly say legacy-peer-deps “causes npm to completely ignore peerDependencies” and is used when peer ranges collide; without it, installs can fail on peer resolution. This repository still has conflicting peers (for example client/package.json includes react@^17.0.1 with enzyme-adapter-react-16@^1.15.2) and scripts that run bare npm install (such as client’s install:clean), so reverting this line is likely to reintroduce the install/build failure the reverted fix was addressing.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant