Revert "fix(railway): add .npmrc with legacy-peer-deps to fix Nixpacks build conflict"#332
Revert "fix(railway): add .npmrc with legacy-peer-deps to fix Nixpacks build conflict"#332Om7035 wants to merge 1 commit into
Conversation
…s build …" This reverts commit 4f6230a.
✅ Deploy Preview for quotevote canceled.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf7cc6385d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1 +0,0 @@ | |||
| legacy-peer-deps=true No newline at end of file | |||
There was a problem hiding this comment.
Keep project-level legacy-peer-deps configuration
Deleting this root .npmrc removes the default legacy-peer-deps=true behavior for every plain npm install in the monorepo. npm’s config docs explicitly say legacy-peer-deps “causes npm to completely ignore peerDependencies” and is used when peer ranges collide; without it, installs can fail on peer resolution. This repository still has conflicting peers (for example client/package.json includes react@^17.0.1 with enzyme-adapter-react-16@^1.15.2) and scripts that run bare npm install (such as client’s install:clean), so reverting this line is likely to reintroduce the install/build failure the reverted fix was addressing.
Useful? React with 👍 / 👎.
Reverts #331