Skip to content

perf(preloader): listen to qwikloader for early preloading #7610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented May 18, 2025

@wmertens wmertens requested review from a team as code owners May 18, 2025 10:21
Copy link
Contributor

github-actions bot commented May 18, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview e37f14e

Copy link

changeset-bot bot commented May 18, 2025

⚠️ No Changeset found

Latest commit: e37f14e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wmertens wmertens force-pushed the tweak-preloader branch 2 times, most recently from 4c51497 to 9ad3c03 Compare May 18, 2025 14:39
this doesn't seem to interfere with LCP because it's small and async, and it allows listening to qwikloader events sooner.
Copy link

pkg-pr-new bot commented May 18, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7610
npm i https://pkg.pr.new/@builder.io/qwik-city@7610
npm i https://pkg.pr.new/eslint-plugin-qwik@7610
npm i https://pkg.pr.new/create-qwik@7610

commit: e37f14e

this doesn't impact LCP and reduces download size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant