chore: improve CSR starter 🍒 #8039
Conversation
|
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
| qwikVite({ csr: true }), | ||
| tsconfigPaths({ root: "." }), | ||
| config.mode === "development" && | ||
| viteStaticCopy({ |
There was a problem hiding this comment.
This is needed to resolve
<script async type="module" src="@qwik.dev/core/qwikloader.js"> in dev mode.
There was a problem hiding this comment.
why is it needed in dev mode?
There was a problem hiding this comment.
without this fix, in dev mode, is not resolving and serving the file correctly.
There was a problem hiding this comment.
What about using the qwikloader: "inline" prop we just brought back in v1.17.0?
There was a problem hiding this comment.
Hmm that seems wrong, vite should be parsing the index.html and resolving the qwikloader.js into a module.
Isn't it working? I thought I tested it.
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Qwik browser-only starter</title> | ||
| <title>Qwik SPA starter</title> |
There was a problem hiding this comment.
Hmmm - SPA implies multiple routes, no? Without qwik-router there's no routes...
Technically, it's the CSR starter.
| qwikVite({ csr: true }), | ||
| tsconfigPaths({ root: "." }), | ||
| config.mode === "development" && | ||
| viteStaticCopy({ |
There was a problem hiding this comment.
Hmm that seems wrong, vite should be parsing the index.html and resolving the qwikloader.js into a module.
Isn't it working? I thought I tested it.
3 participants
CSR or SPA is more understandable then browser-only IMHO.