Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-components): hint component #354

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat(react-components): hint component #354

wants to merge 10 commits into from

Conversation

VojtechVidra
Copy link
Member

No description provided.

@VojtechVidra VojtechVidra marked this pull request as ready for review April 5, 2025 09:48
@OPesicka OPesicka requested review from OPesicka and Copilot and removed request for OPesicka April 6, 2025 07:45
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • workspaces/styles/src/hint.css: Language not supported
  • workspaces/styles/src/index.css: Language not supported
  • workspaces/styles/src/vars.css: Language not supported
Comments suppressed due to low confidence (2)

workspaces/react-components/src/tour-components/hint.tsx:47

  • [nitpick] The onClose callback uses 'props.cancel' here, which is inconsistent with the naming used in the common Hint component. Consider standardizing the callback name (e.g., using 'close' everywhere) to improve API consistency.
onClose={props.showCloseButton ? props.cancel : undefined}

workspaces/react-components/src/components/hint.tsx:38

  • [nitpick] The onClose callback uses 'props.close' in this component, whereas a different name is used in tour-components/hint.tsx. Aligning the callback naming across Hint component implementations could reduce confusion for end users of the component.
onClose={props.showCloseButton ? props.close : undefined}

@VojtechVidra VojtechVidra linked an issue Apr 11, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Hint component
2 participants