Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade log message about plugin without override argument to debug from warning #3063

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yarikoptic
Copy link
Contributor

Summary of changes

Original issue

was worked around by providing a fall back call without "override" in

As a result any user with such a store (in our case just <class 'rdflib.plugins.memory.IOMemory'>) is flooded with such warnings pointing to that issue #1880 and for all means and purposes AFAIK just need to ignore them since there is nothing user can do to address it.

That raises the question on why is it a Warning at a user level and not some debug message for developers/troubleshooting etc? Hence I am lowering it to debug level to bring peace of mind to users of the library.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • If the change has a potential impact on users of this project:
    • Added or updated tests that fail without the change.
    • Updated relevant documentation to avoid inaccuracies.
    • Considered adding additional documentation.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

… from warning

Original issue

- RDFLib#1880

was worked around by providing a fall back call without "override" in

- RDFLib#2018

As a result any user with such a store (in our case just <class
'rdflib.plugins.memory.IOMemory'>) is flooded with such warnings pointing to
that issue RDFLib#1880 and for all means and purposes AFAIK just need to ignore
them since there is nothing user can do to address it.

That raises the question on why is it a Warning at a user level and not some
debug message for developers/troubleshooting etc?  Hence I am lowering it to
debug level to bring peace of mind to users of the library.
@coveralls
Copy link

Coverage Status

coverage: 90.334%. remained the same
when pulling e336421 on yarikoptic:rf-no-warning
into 62c528d on RDFLib:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants