Skip to content

Add test function to validate Transition node ID immutability #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add test function to validate Transition node ID immutability #19

wants to merge 2 commits into from

Conversation

claudiosdc
Copy link
Contributor

@dr-orlovsky, as per your request, I am reopening this PR, now against the master branch.

@claudiosdc
Copy link
Contributor Author

@dr-orlovsky, I realized that the test function was not correct since the Transition::conceal_all() function ONLY conceals the values (amounts) of the assignments, not the seals. So I had to write a function that does that. You will need to remerge this PR for fix it.

@dr-orlovsky
Copy link
Member

Cool. Yeah, we need to rename those conceal methods.

Don't know how to re-merge in github; probably another PR against those branch is needed

@claudiosdc
Copy link
Contributor Author

Don't know how to re-merge in github; probably another PR against those branch is needed

@dr-orlovsky, I have created a new PR (#20) that applies the fix for the test function to the fix/nodeid-mut branch.

@dr-orlovsky
Copy link
Member

Closing since it is already merged via #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@claudiosdc @dr-orlovsky