Skip to content

Refactoring v0.11 into v0.11.1 in style of v0.12 simplifications #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 73 commits into
base: master
Choose a base branch
from

Conversation

dr-orlovsky
Copy link
Member

@dr-orlovsky dr-orlovsky commented May 11, 2025

This PR by Bitfinex team summarizes their 4-month work on making v0.11 as simple as possible, including taking many ideas from v0.12 (seal unification, monimorphisation of contracts over specific underlying chain; state unification, removal of Pedersen commitments etc)

dr-orlovsky and others added 30 commits September 18, 2024 10:25
testnet may have blocks which timestamps are not aligned with their heights
fmt keeps changing all the time. Now they introduced new "editions" feature, which by default does a lot of changes to the codebase by mingling with alphabetical sorting of all imports, doing them in case-insentive way. This PR allows to avoid that dramatic changes
due to rustfix dependency
@dr-orlovsky dr-orlovsky mentioned this pull request May 11, 2025
@dr-orlovsky dr-orlovsky changed the title Refactoring of v0.11 into v0.11.1 Refactoring v0.11 into v0.11.1 in style of v0.12 simplifications May 11, 2025
@dr-orlovsky dr-orlovsky changed the base branch from v0.11 to master May 11, 2025 14:10
Copy link

codecov bot commented May 11, 2025

Codecov Report

Attention: Patch coverage is 4.58265% with 583 lines in your changes missing coverage. Please review.

Project coverage is 9.8%. Comparing base (52592c6) to head (9267913).

Files with missing lines Patch % Lines
src/validation/validator.rs 0.0% 135 Missing ⚠️
src/schema/schema.rs 0.0% 88 Missing ⚠️
src/validation/logic.rs 0.0% 76 Missing ⚠️
src/vm/op_contract.rs 0.0% 72 Missing ⚠️
src/operation/assignments.rs 0.0% 70 Missing ⚠️
src/operation/layer1.rs 0.0% 37 Missing ⚠️
src/operation/bundle.rs 6.5% 29 Missing ⚠️
src/vm/contract.rs 0.0% 19 Missing ⚠️
src/validation/schema.rs 0.0% 16 Missing ⚠️
src/operation/operations.rs 0.0% 11 Missing ⚠️
... and 9 more

❌ Your patch check has failed because the patch coverage (4.6%) is below the target coverage (60.0%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #288     +/-   ##
=======================================
- Coverage    14.1%   9.8%   -4.3%     
=======================================
  Files          29     27      -2     
  Lines        3948   2674   -1274     
=======================================
- Hits          558    262    -296     
+ Misses       3390   2412    -978     
Flag Coverage Δ
rust 9.8% <4.6%> (-4.3%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants