DBAAS-831: update DBaaSConnection status to conform to the Provisioned Service ducktype defined in the Service Binding Specification for Kubernetes #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 13, 2022
…d Service ducktype defined in the Service Binding Specification for Kubernetes
xieshenzh
requested review from
jeremyary,
jianrongzhang89,
redhatHameed and
tchughesiv
as code owners
|
heya, gonna place hold back just until we get the release issues worked out and get a game plan for next release. Thanks! |
baijum
reviewed
Oct 18, 2022
Comment on lines
+7
to
+8
| labels: | ||
| servicebinding.io/provisioned-service: "true" |
There was a problem hiding this comment.
There is a patch file with the same label: config/crd/patches/service_binding_labels.yaml
Please remove one of these.
There was a problem hiding this comment.
The patch file is used to generate this CRD file in the bundle.
@jeremyary Any update about this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current annotation-based approach is supported in SBO. But SBO encourages every service provider to follow the core spec recommended Provisioned Service based approach: https://github.com/servicebinding/website/blob/main/service-provider.md
Jira: https://issues.redhat.com/browse/DBAAS-831
Verification Steps
Verify by perform the service binding with various providers.
Type of change
Checklist (Definition of Done)