Improve Actions workflows and add codeowners and copilot instructions#41
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the CI/CD infrastructure by replacing a monolithic build pipeline with separate, specialized workflows and adds browser compatibility fixes for Cypress tests. The changes improve deployment security by adopting OIDC authentication, enable multi-browser E2E testing, and provide comprehensive documentation for GitHub Actions best practices.
- Splits the single workflow into separate CI build and AWS deployment workflows with OIDC authentication
- Adds conditional test execution to skip clipboard-related tests in Firefox due to browser API limitations
- Updates JSON validator tests to use regex patterns for cross-browser error message compatibility
- Adds comprehensive GitHub Actions and Angular development instructions
- Configures Dependabot grouping and code ownership
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/build.yml | New CI workflow with multi-browser E2E testing strategy |
| .github/workflows/deploy.yml | New deployment workflow using OIDC for secure AWS authentication |
| .github/workflows/build-pipeline.yml | Removed legacy monolithic workflow |
| cypress/e2e/tools/time-converter.cy.ts | Added browser-specific conditional test execution for clipboard tests |
| cypress/e2e/tools/json-validator.cy.ts | Updated error assertions to use regex patterns for cross-browser compatibility |
| cypress/e2e/tools/base64-encoder.cy.ts | Added browser-specific conditional test execution for clipboard tests |
| .github/instructions/github-actions.instructions.md | Added comprehensive GitHub Actions best practices documentation |
| .github/instructions/angular.instructions.md | Added Angular development standards and guidelines |
| .github/dependabot.yml | Configured dependency grouping for npm packages |
| .github/CODEOWNERS | Added code ownership configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.