-
Notifications
You must be signed in to change notification settings - Fork 9
Init work on postgresql implementation to the dashboard to get cases inside PGSQL #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
aluneau
wants to merge
51
commits into
RHsyseng:main
Choose a base branch
from
aluneau:postgres-implementation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implements sqlalchemy 2.0 style ORM mapping
fixes black and ruff linter issues fixes black linter issues fixes ruff and flake8 linter issues fixes black linter issue fixes isort linter issues
ef2ebf2
to
36f64e4
Compare
code generated by Cursor AI
generated by Cursor AI
This reverts commit c1d5a9f.
Postgres with ci testing
- raises early exception if the Postgres env variables are missing - sets up test DB session with SQLite indpeendent of the Postgres config
Eliminated fixture duplication by removing duplicate fake_data and test_db_session fixtures from test_database.py, now using centralized versions from conftest.py. Created factory methods to eliminate repetitive test setup and broke down oversized test methods into focused, single-responsibility tests. Centralized inconsistent data handling by creating helper functions that replaced scattered product_version extraction logic across 4 test methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
I did initiate work on postgresql database implementation.
The goal would be to get cases on the postgresql database as well as on Redis for a start, then add further things on the postgresql
I want to use Alchemy as ORM
What is added:
What's left to do