Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOSTANDFOUND.md: add missing URL, fix Markdown typo [backport 2025.01] #21165

Conversation

MrKevinWeiss
Copy link
Contributor

Backport of #21154

Contribution description

In Pull Request #18562, the removal of MIPS support was documented and the headline had the right Commit ID, however the URL was not added to the link section below.

In Pull Request #21146, a : was added after the headline, leading to Doxygen not recognizing the link and therefore not applying it.
Unfortunately while this PR was open, I didn't see it in time, so now it has to be fixed afterwards.

I think both PRs are from @MrKevinWeiss, but I don't want to blame him. I fought for hours with the LOSTANDFOUND.md to find the bug described in #21106, so I know how easy it is to get Markdown angry :D

Testing procedure

The documentation should still build and now show the links (they are still broken because of #21106, BUT there should now be <a href=... in the headlines.

Issues/PRs references

Corrects the regressions introduced in #18562 and #21146.

@MrKevinWeiss MrKevinWeiss requested a review from jia200x as a code owner January 27, 2025 10:15
@MrKevinWeiss MrKevinWeiss added Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Jan 27, 2025
@MrKevinWeiss MrKevinWeiss requested a review from miri64 January 27, 2025 10:16
@riot-ci
Copy link

riot-ci commented Jan 27, 2025

Murdock results

✔️ PASSED

f01072d LOSTANDFOUND.md: add missing URL, fix Markdown typo

Success Failures Total Runtime
1 0 1 01m:41s

Artifacts

@MrKevinWeiss MrKevinWeiss added this pull request to the merge queue Jan 27, 2025
Merged via the queue into RIOT-OS:2025.01-branch with commit 3e77360 Jan 27, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants