tests/drivers/candev: minor cleanup #21175
Open
+58
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
added
Area: tests
Murdock results❌ FAILED 8d0ac30 tests/drivers/candev: minor cleanup
Build failures (1)
Artifacts |
- Do not hard code the number of the CAN interface to use. (This also allows specifying it via make command line / environment variable.) - Make less use of preprocessor and rely on compiler to eliminate dead branches and unused variables.
maribu
force-pushed
the
tests/drivers/candev
branch
from
99715d7 to
8d0ac30
Compare
benpicco
reviewed
Jan 30, 2025
| #else | ||
| /* add includes for other candev drivers here */ | ||
| #ifdef BOARD_SAME54_XPRO | ||
| # include "periph/gpio.h" |
There was a problem hiding this comment.
That is annoying, isn't it?
I'll add a __attribute__((weak)) board_enable_can_transceiver(can_t *dev); and a __attribute__((weak)) board_disable_can_transceiver(can_t *dev); into the periph_can driver, so that we do not need to have magic stuff at application level, but rather let the board hook into can_init().
But that is not independent of this PR and will be a follow up.
There was a problem hiding this comment.
We already have a CAN transceiver interface, it's just not integrated with candev 😩
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Testing procedure
The test should behave as before. (Unless one would pass e.g.
CAN_DEV=1, in which case the 2nd CAN interface would be used instead of the first.)Issues/PRs references
None