-
Notifications
You must be signed in to change notification settings - Fork 2.1k
core: replace header guards with #pragma once #21405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @JerelJr, First all all welcome to the RIOT community and thank you for your first contribution. :) It seems like the changes broke something, as the CI build does not complete anymore: https://ci.riot-os.org/details/9d47c2b748804fc4820232a5810c9d0e Generally speaking, the Today the Hard Freeze will start and the Soft Freeze is already in place, so this is not a feature that could be merged before the next release: https://forum.riot-os.org/t/release-2025-04-soft-freeze-in-effect/4497/1 Perhaps you can look at the error in the CI system to try to locate which change broke the build in the meantime :) |
Thank you for your feedback! I started with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Would you mind squashing the commits into one?
core/lib/include/ringbuffer.h: removed trailing newline core/lib/include/irq.h: restored header guard for irq.h to resolve build errors core/lib/include/irq.h: added trailing newline to irq.h
121d118
to
04dafd5
Compare
Since an agreement to use |
Thx a lot! |
Contribution description
Updated header files in the
core
directory and its subdirectories by switching from header guards to#pragma once
Testing procedure
I used this script to find and correct header files that need to be changed. Change
RIOT_PATH
to the directory to be fixedIssues/PRs references
See issue #21335