Skip to content

Dettaglio export popup avviso su android#511

Merged
theperu merged 3 commits intoRIP-Comm:mainfrom
AlessandroBonomo28:main
Feb 6, 2026
Merged

Dettaglio export popup avviso su android#511
theperu merged 3 commits intoRIP-Comm:mainfrom
AlessandroBonomo28:main

Conversation

@AlessandroBonomo28
Copy link
Copy Markdown
Contributor

🎯 Description

quando l'utente prova a salvare nella root directory di android ha un output più chiaro sul perchè non funziona e su dove salvare il file

Closes: # (issue)

📱 Changes

  • aggiunto un popup che, nel momento dell'esportazione, durante il salvataggio, se il dispositivo è android, avvisa che il file non può essere salvato in directory root ma in una directory tipo downloads o documents.

🧪 Testing Instructions

Behaviour

  1. Apri l'app
  2. Prova a esportare nella root directory

📸 Screenshots / Screen Recordings (if applicable)

Documentazione dell'errore da utente discord:

20260130_225757.mp4

🔍 Checklist for reviewers

  • Code is formatted correctly
  • Tests are passing
  • New tests are added (if needed)
  • Style matches the figma/designer requests
  • Tested on:
    • iOS
    • Android

✍️ Additional Context

Questo errore era stato segnalato su discord da un utente in chat generale.

quando l'utente prova a salvare nella root directory di android ha un output più chiaro sul perchè non funziona e su dove salvare il file
Copy link
Copy Markdown
Collaborator

@theperu theperu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for your contribution, the idea is correct but I wouldn't hardcode all the paths because the same error is thrown if you create a folder in the root and try to save the file there. Also different devices might have a different path.
What I would do is catch the actual error that is thrown when this happens and show that dialog no matter the path

@AlessandroBonomo28
Copy link
Copy Markdown
Contributor Author

AlessandroBonomo28 commented Feb 5, 2026

Hi! Thanks for your contribution, the idea is correct but I wouldn't hardcode all the paths because the same error is thrown if you create a folder in the root and try to save the file there. Also different devices might have a different path. What I would do is catch the actual error that is thrown when this happens and show that dialog no matter the path

Hello, you are right, I removed the hardcoded path, now when the saving error happens it shows the simplified message. Hope it helps

Copy link
Copy Markdown
Collaborator

@theperu theperu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@theperu theperu merged commit c43ff92 into RIP-Comm:main Feb 6, 2026
1 check passed
Mattia-Sacchi pushed a commit to Mattia-Sacchi/sossoldi that referenced this pull request Mar 6, 2026
Dettaglio export popup avviso su android
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants