fix: Include recurring transactions in account balance calculations#517
Merged
lucaantonelli merged 1 commit intoRIP-Comm:mainfrom Feb 27, 2026
Merged
Conversation
Collaborator
|
LGTM! |
Mattia-Sacchi
pushed a commit
to Mattia-Sacchi/sossoldi
that referenced
this pull request
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Description
Recurring transaction occurrences were not contributing to account balances. When
checkRecurringTransactions()runs at app startup, it generates realtransactionrows (withrecurring = 1) for each past-due occurrence. However, three queries inaccount_repository.dartexplicitly filtered out any transaction withrecurring = 1, meaning these auto-generated entries were completely invisible to balance calculations.This fix removes that filter so that recurring transaction occurrences are correctly included in account totals, daily balance charts, and monthly balance charts.
Closes: N/A
📱 Changes
recurringFilterfromselectAll()inAccountRepository— fixes account totals shown on the dashboard and accounts pagerecurrentFilterfromaccountDailyBalance()— fixes the daily balance chart on the account detail pagerecurrentFilterfromaccountMonthlyBalance()— fixes the monthly balance chart on the account detail page🧪 Testing Instructions
Behaviour
fromDateat least one recurrence period in the pastcheckRecurringTransactions()runs and generates the occurrence(s)🔍 Checklist for reviewers