Skip to content

[Enchant] Add Budget Dialog#522

Open
Punlork wants to merge 3 commits intoRIP-Comm:mainfrom
Punlork:main
Open

[Enchant] Add Budget Dialog#522
Punlork wants to merge 3 commits intoRIP-Comm:mainfrom
Punlork:main

Conversation

@Punlork
Copy link
Copy Markdown

@Punlork Punlork commented Mar 12, 2026

🎯 Description

Improve Add Budget Dialog design

Closes: # (issue)

📱 Changes

  • Describe key changes made
  • List any new features, bug fixes, or refactors
  • Include additional details if necessary

🧪 Testing Instructions

Behaviour

  1. Do this
  2. Do that

📸 Screenshots / Screen Recordings (if applicable)

If your PR involves UI changes, please add screenshots or screen recordings here.

Platform Before After
Android Screenshot_1773311485
iOS Simulator Screenshot - iPhone 16 Pro Max - 2026-03-12 at 17 38 16

🔍 Checklist for reviewers

  • Code is formatted correctly
  • Tests are passing
  • New tests are added (if needed)
  • Style matches the figma/designer requests
  • Tested on:
    • iOS
    • Android

✍️ Additional Context

Add any other information that we might know

Copy link
Copy Markdown
Collaborator

@theperu theperu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! autofocus, textAlign: center, and the SizedBox width fix are all great additions. A couple of small consistency notes:

  • shape can be removed, M3 already rounds dialog corners and no other dialog in the project overrides this.
  • insetPadding: Sizes.edgeInsetsTablet this constant is tablet-specific, so it'll make the dialog narrower than intended on phones. Safe to just remove the override entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants