Feat: Category and Account deletion#524
Open
lucaantonelli wants to merge 6 commits intoRIP-Comm:mainfrom
Open
Conversation
theperu
requested changes
Mar 28, 2026
Collaborator
theperu
left a comment
There was a problem hiding this comment.
Hi! There are a few things that I noticed:
- The migration version is 6 instead of 7
- When I delete a category there is no dialog similar to the one that we have for the accounts
- When I delete a category that has a recurring transaction associated the category is deleted but the recurring transaction is not
- When I delete an account that has a recurring transaction associated the account is deleted but the recurring transaction widget does not update until I close and reopen the app
- When I delete an account that is set as main account it gets deleted but I still see it as the default option when I add a new transaction (this probably happens also to the counts towards net worth BTW)
- When I delete a category/subcategory I still see it in the list of possible categories when I add a new transaction, the list updates after closing and reopening the app
- If I delete a category that has a budget when I go back to the planning page I see an error
Collaborator
Author
Hi, all the problem should be fixed, i couldn't replicate the problem at point 5, on my end is working correctly. I also found an error in budgets, if you create a budget and delete it then when recreating it for same category doesn't show anymore because active still remain false when updating, i should have fixed this as well. |
theperu
requested changes
Apr 2, 2026
Collaborator
theperu
left a comment
There was a problem hiding this comment.
@lucaantonelli I still see a couple of issues:
- I can't delete subcategories
- If I open the new transaction page, open the list of categories, then I go to settings and delete a category when I come back to add a transaction again I still see the deleted category in the list
- When an account is deleted I would set the countNetWorth to false to avoid future issues with it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Description
Handle categories and accounts deletion correctly. Add a deleted_at field on both tables.
Closes: #177
📱 Changes
🧪 Testing Instructions
🔍 Checklist for reviewers