Clean up Audio code, Add Mono/Stereo switch#20
Conversation
|
Hi faux123, sorry for the delay. Could you separate the audio changes from the performance optimizations? |
EnableSounds main: Unify all sound controls under 1 setting Signed-off-by: Paul Reioux <reioux@gmail.com>
faux123
changed the title
Done. Please review and merge. Thanks. |
|
The sound is barely audible from rgb30 speakers at max volume. |
|
this needs the corresponding PR from distribution, as the platforms have issue with master audio volume. |
|
That's how I tested as well, I did: |
|
I updated a current flash, if it is due to that. If it only works on fresh flash you could to put corresponding changes in |
| if (mMedia) | ||
| { | ||
| // use : vlc �long-help | ||
| // use : vlc �long-help |
There was a problem hiding this comment.
can you remove this change?
| //auto ss_video_mute = std::make_shared<SwitchComponent>(mWindow); | ||
| //ss_video_mute->setState(Settings::getInstance()->getBool("ScreenSaverVideoMute")); | ||
| //addWithLabel(_("MUTE VIDEO AUDIO"), ss_video_mute); | ||
| //addSaveFunc([ss_video_mute] { Settings::getInstance()->setBool("ScreenSaverVideoMute", ss_video_mute->getState()); }); |
There was a problem hiding this comment.
Without any information about commented lines I don't find it very useful to keep them. Can you remove the lines?
| // ctlStopMusic->setState(Settings::getInstance()->getBool("EnableSounds")); | ||
| // addWithLabel(_("STOP MUSIC ON SCREENSAVER"), ctlStopMusic); | ||
| // addSaveFunc([ctlStopMusic] { Settings::getInstance()->setBool("EnableSounds", ctlStopMusic->getState()); }); | ||
| // } |
There was a problem hiding this comment.
Without any information about commented lines I don't find it very useful to keep them. Can you remove the lines?
|
Do I under stand correctly that with these changes, that background music, sounds from video and navigation sounds is now all of them or none of them? |
2 participants
for SX20 or other mono speaker devices, allow user to switch between stereo and mono for better experience audio experience. This PR MUST go with the corresponding PR on the distribution side.
Fix audio stream being held during blank screensaver
the audio streams are constantly being consumed and active thus leading
to 10-25% additional CPU resources consumed. Release AudioManager when
blank screen is active to let those audiostreams go into idle/suspend so the
system can go into proper idle. This saves another 20-25% battery drain during
screensaver event.
Fixes # (issue)
mono speaker not getting audio from left channel from emulators
Type of change
How Has This Been Tested Locally?
Tested with PowKiddy SX20, PowKiddy RGB30 and PowKiddy X55 by switch between mono and stereo
Test Configuration:
Checklist:
Pull Request Template