-
Notifications
You must be signed in to change notification settings - Fork 97
wait() failing for the default stream 0 #3873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3873 +/- ##
========================================
Coverage 92.40% 92.40%
========================================
Files 520 520
Lines 22485 22485
========================================
Hits 20778 20778
Misses 1707 1707 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this relies on undocumented behavior, a unit test needs to be added.
This PR fixes these two issues when using the default stream on the GPU: i.e. via
MIGRAPHX_ENABLE_NULL_STREAM=1
:Trying to
verify
on a model, (resnet50v2 here) gives this exception:context.hpp:365: get_elapsed_ms: Failed hipEventElapsedTime: device not ready
Trying to run
perf
on a model with the default stream gives more optimistic results, as the gpu-sync-up is essentially bypassed, incorrectly.