Skip to content

failure of test_topk<migraphx::shape::float_type, 1000, 120000> is based on the input data pattern #4376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lakhinderwalia wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

failure of test_topk<migraphx::shape::float_type, 1000, 120000> is based on the input data pattern #4376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/include/migraphx/generate.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ template <class T, MIGRAPHX_REQUIRES(is_signed<T>{} and not is_floating_point<T>
constexpr T normalize(unsigned long z, random_mode m)
{
const long long max =
(m == random_mode::legacy) ? 1ULL << (sizeof(T) * 5) : 1ULL << (sizeof(T) * 6 - 1);
(m == random_mode::legacy) ? 1ULL << (sizeof(T) * 5) : 1ULL << (sizeof(T) * 8 - 2);
const auto half_max = max / 2;
auto result = half_max - (z % max);
// Expected output: between -half_max and half_max
Expand Down Expand Up @@ -123,7 +123,7 @@ struct xorshift_generator
template <class T>
auto generate_tensor_data(const migraphx::shape& s,
unsigned long seed,
random_mode m = random_mode::legacy)
random_mode m = random_mode::random)
{
auto result = make_shared_array<T>(s.element_space());
std::generate(result.get(), result.get() + s.element_space(), xorshf96_generator<T>{seed, m});
Expand All @@ -142,7 +142,7 @@ MIGRAPHX_EXPORT argument fill_argument(shape s, double value = 0);

MIGRAPHX_EXPORT argument generate_argument(shape s,
unsigned long seed = 0,
random_mode m = random_mode::legacy);
random_mode m = random_mode::random);

MIGRAPHX_EXPORT literal generate_literal(shape s, unsigned long seed = 0);

Expand Down
Loading