[7.1.1] check if instruction is actually a literal (#4388) #4401
+36
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compare_literals function was calling instruction::get_literal() on instructions that were not necessarily literal instructions. The function assumed that if an instruction could be evaluated (eval() returns non-empty), it was safe to call get_literal(), but this assumption was incorrect.
causten
changed the title
aarushjain29
approved these changes
Oct 21, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/rocm-rel-7.1 #4401 +/- ##
========================================================
- Coverage 92.26% 92.26% -0.00%
========================================================
Files 560 560
Lines 26358 26356 -2
========================================================
- Hits 24319 24317 -2
Misses 2039 2039
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The compare_literals function was calling instruction::get_literal() on instructions that were not necessarily literal instructions. The function assumed that if an instruction could be evaluated (eval() returns non-empty), it was safe to call get_literal(), but this assumption was incorrect.
Changelog Category