Add more toolchain flags for Windows, required by math libs. #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
commented
Apr 3, 2025
ScottTodd
commented
Apr 3, 2025
ScottTodd
commented
Apr 3, 2025
Base automatically changed from
users/scotttodd/windows-math-prim
to
users/scotttodd/windows-math-fft
April 7, 2025 16:51
ScottTodd
force-pushed
the
users/scotttodd/windows-math-fft
branch
from
f9fd2f7 to
daad0ce
Compare
ScottTodd
force-pushed
the
users/scotttodd/windows-math-extra-flags
branch
from
ceb4ce9 to
530a072
Compare
marbre
approved these changes
Apr 7, 2025
ScottTodd
commented
Apr 7, 2025
| string(APPEND _toolchain_contents "set(CMAKE_C_FLAGS_INIT )\n") | ||
| string(APPEND _toolchain_contents "set(CMAKE_CXX_FLAGS_INIT \"-DWIN32 -D_CRT_SECURE_NO_WARNINGS -DNOMINMAX \")\n") | ||
| string(APPEND _toolchain_contents "set(CMAKE_CXX_FLAGS_INIT \"-DWIN32 -D_CRT_SECURE_NO_WARNINGS -DNOMINMAX -fms-extensions -fms-compatibility -D_ENABLE_EXTENDED_ALIGNED_STORAGE \")\n") |
There was a problem hiding this comment.
Oh wait... these are getting sent to the regular toolchain too:
[build] [amd-llvm] [188/5733 2% :: 0.752] Building CXX object lib\Support\CMakeFiles\LLVMSupport.dir\UnicodeNameToCodepointGenerated.cpp.obj
[build] [amd-llvm] cl : Command line warning D9002 : ignoring unknown option '-fms-extensions'
[build] [amd-llvm] cl : Command line warning D9002 : ignoring unknown option '-fms-compatibility'
I'll adjust the logic a bit.
ScottTodd
force-pushed
the
users/scotttodd/windows-math-extra-flags
branch
from
1c55238 to
4599c59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #36.
This, together with #358, fixes test compilation for hipCUB and rocThrust.
Details:
-fms-extensionsand-fms-compatibilityare documented here: https://clang.llvm.org/docs/MSVCCompatibility.html-D_ENABLE_EXTENDED_ALIGNED_STORAGEto acknowledge using extended aligned storage: https://github.com/ROCm/hipCUB/blob/40f174daf777856949c624317c16ffbfe93e9108/rmake.py#L105-L108