Add aomp-shellcheck script #1463
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a helper script to wrap the 'shellcheck' utility, aiming to split checks into (a) those that should be fixed by hand, (b) those which can be fixed automatically with reasonable precision, and (c) those which should always be ignored.
This patch moves some potentially semantics-altering automatic fixes to the fixByHand list.
This patch allows multiple scripts to listed for aomp-shellcheck, and contains some cleanups based on running shellcheck on that script itself.
This patch adds a --check-only option to aomp-shellcheck to avoid automatically altering files, e.g. when called via an automation system.
jplehr
reviewed
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a new aomp-shellcheck script (by Gregory Rodgers) and some additional improvements, including a new "--check-only" option to help with automation.