Skip to content

Conversation

@DominikAdamski
Copy link
Contributor

@DominikAdamski DominikAdamski commented Oct 21, 2025

Merge only with: ROCm/llvm-project#328

Motivation

Modify aomp scripts to test PR: ROCm/llvm-project#328

Technical Details

This PR adds required changes to build GPU LLVM IR Flang runtime.

Test Plan

Test procedure:

  1. Apply this PR
  2. Apply LLVM PR: [Flang-RT] Changes required for embedded GPU LLVM IR Flang runtime llvm-project#328 for LLVM
  3. Build AOMP :
./build_aomp.sh

a) (Optional) Build flang_rt.hostdevice if you want to use old -lflang_rt.hostdevice

./build_llvm-flang-rt-host-dev.sh
  1. Test smoke-fort-dev for the new Flang RT:
IMPLICIT_GPU_FLANG_RT=1 ./check_smoke_fort_dev.sh 
  1. (Optional) Test smoke-fort-dev for the old Flang RT (flang_rt.hostdevice):
    Make sure, you built flang_rt.hostdevice (point 3a), and launch smoke_fort_dev tests (no additional env vars)

Test Result

No regression for smoke-fort-dev.

@DominikAdamski DominikAdamski changed the title [WIP] No flang hostdevice runtime flag [Flang-RT] No flang hostdevice runtime flag Dec 3, 2025
@DominikAdamski DominikAdamski marked this pull request as ready for review December 3, 2025 13:15
Copy link
Contributor

@ronlieb ronlieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you desire an nPSDB to be run on this PR ?

@DominikAdamski
Copy link
Contributor Author

do you desire an nPSDB to be run on this PR ?

Only if you can combine this PR and ROCm/llvm-project#328 for nPSDB.

@ronlieb
Copy link
Contributor

ronlieb commented Dec 3, 2025

do you desire an nPSDB to be run on this PR ?

Only if you can combine this PR and ROCm/llvm-project#328 for nPSDB.

we can do that, buildWparameters, and add the two PRs in the proper fields.

@ronlieb
Copy link
Contributor

ronlieb commented Dec 3, 2025

image

@ronlieb
Copy link
Contributor

ronlieb commented Dec 3, 2025

@ronlieb
Copy link
Contributor

ronlieb commented Dec 3, 2025

BwP failed applying aomp, i think aomp PR might need a rebase?

@DominikAdamski DominikAdamski force-pushed the no_flang_hostdevice_runtime branch from 6bc162e to 8522326 Compare December 3, 2025 15:34
@DominikAdamski
Copy link
Contributor Author

DominikAdamski commented Dec 3, 2025

I squashed changes and applied single commit on the top of the aomp-dev branch (last aomp-dev commit: 94cc856 )

@DominikAdamski DominikAdamski force-pushed the no_flang_hostdevice_runtime branch from 8522326 to 19ab0db Compare December 4, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants