Skip to content

Move SetZero functions inside the kernels for Grouped Conv #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

bartekxk
Copy link
Contributor

@bartekxk bartekxk commented May 28, 2025

Proposed changes

This PR should remove all SetZero functions usage from ckProfiler and move this inside the kernel. Each device op knows when SetZero is need.

It will allow MIOpen to remove SetZero from their code for ck kernels. Specifically, it eliminates performance problems caused when SetZero was called unnecessarily.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

aosewski
aosewski previously approved these changes May 28, 2025
@bartekxk bartekxk force-pushed the barkocot/remove-set-zero-fwd branch from 484624d to 0f912ad Compare May 29, 2025 14:36
@bartekxk bartekxk changed the title Disable SetZero before launch kernel for grouped conv fwd Move SetZero functions inside the kernels for Grouped Conv May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants