-
Notifications
You must be signed in to change notification settings - Fork 251
Remove "basic" and universal GEMM tests, and incorporate their test cases into the GEMM pipeline tests #3094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5c3cad to
2c95cba
Compare
Contributor
Author
|
Converted back to draft because of test failures on gfx950 |
2c95cba to
b34d16d
Compare
b34d16d to
16151c1
Compare
2c9d845 to
b6c8c6d
Compare
illsilin
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The "basic" GEMM tests do not test the basic GEMM (pipelines V1 and V2), but rather the V3 pipeline, which is tested by the universal GEMM tests. As for the universal GEMM tests, they have overlapping coverage with the GEMM pipeline tests. The pipeline tests, on the other hand, offer more test coverage per parameter set. Therefore remove the "basic" and universal GEMM tests, and incorporate their test cases into the GEMM pipeline tests.
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered