[CK_TILE] Remove Old CK Tile Stream-K Artifacts #3202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecamartins
force-pushed
the
emimarti/ck_tile/remove_old_streamk
branch
5 times, most recently
from
2c8bf72 to
0d93e6c
Compare
ecamartins
requested review from
ThomasNing,
afagaj,
andriy-ca,
aosewski,
asleepzzz,
bartekxk,
carlushuang,
cgmillette,
coderfeli,
geyyer,
illsilin,
poyenc,
qianfengz,
shumway,
tenpercent and
vidyasagar-amd
as code owners
cgmillette
reviewed
Nov 18, 2025
test/ck_tile/gemm_streamk/test_streamk_tile_partitioner_common.hpp
Outdated
Show resolved
Hide resolved
amd-anclark
previously approved these changes
Nov 19, 2025
ecamartins
force-pushed
the
emimarti/ck_tile/remove_old_streamk
branch
from
0d93e6c to
998accc
Compare
cgmillette
previously approved these changes
Nov 19, 2025
Collaborator
cgmillette
left a comment
cgmillette
left a comment
There was a problem hiding this comment.
Nice work, lgtm!
Future tests will go into tile engine, so these are good for spot-checking.
ecamartins
force-pushed
the
emimarti/ck_tile/remove_old_streamk
branch
from
998accc to
87b5186
Compare
The original CK Stream-K implementation was based on old CK's Stream-K block to C tile map. However, this implementation did not align with the original Stream-K paper. Thus, we implemented a new tile partitioner and associated Stream-K kernel, which was placed in the reboot namespace. Now that the new Stream-K implementation is ready, this change removes all artifacts of the old implementation. Specifically, the following changes were made: - Removes old Stream-K tile partitioner from CK Tile - Removes the reboot namespace such that the new implementation resides in the ck_tile namespace only. - Adds tests for bf8 and fp8 using the new implementation - Removes tests for the old implementation - Remove the v2 suffix from the new CK Tile Tile Partitioner derived classes. - Updates Stream-K Kernel ops file to use /** commenting style.
ecamartins
force-pushed
the
emimarti/ck_tile/remove_old_streamk
branch
from
87b5186 to
3187ee6
Compare
cgmillette
approved these changes
Nov 20, 2025
7 tasks
AviralGoelAMD
pushed a commit
that referenced
this pull request
Nov 28, 2025
* Remove old CK Tile Stream-K implementation The original CK Stream-K implementation was based on old CK's Stream-K block to C tile map. However, this implementation did not align with the original Stream-K paper. Thus, we implemented a new tile partitioner and associated Stream-K kernel, which was placed in the reboot namespace. Now that the new Stream-K implementation is ready, this change removes all artifacts of the old implementation. Specifically, the following changes were made: - Removes old Stream-K tile partitioner from CK Tile - Removes the reboot namespace such that the new implementation resides in the ck_tile namespace only. - Adds tests for bf8 and fp8 using the new implementation - Removes tests for the old implementation - Remove the v2 suffix from the new CK Tile Tile Partitioner derived classes. - Updates Stream-K Kernel ops file to use /** commenting style. * Remove v2 from tile partitioner validation function names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The original CK Stream-K implementation used a Tile Partitioner that was based on old CK's Stream-K block to C tile map. However, old CK's implementation did not align with the original Stream-K paper. Thus, we implemented a new Tile Partitioner (#3018) and associated Stream-K Kernel (#3064). The new CK Tile Stream-K kernel implementation was placed in the
rebootnamespace.Now that all functionality for the new implementation is in place, including examples (#3107), we can now remove the old CK tile Stream-K implementation. Thus, this PR makes the following changes:
rebootnamespace such that the new implementation is in theck_tilenamespace only.Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed files