Skip to content

Find pyversion at build time 0.5.0 #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: rocm-jaxlib-v0.5.0
Choose a base branch
from

Conversation

mrodden
Copy link
Collaborator

@mrodden mrodden commented Mar 28, 2025

This is the 0.5.0 branch version, ported from rocm-main

mrodden and others added 3 commits March 28, 2025 16:55
Move defaults for these up to ci_build python
We also add some error catching logic in the
python script to clean up weirdness coming
from the build scripts.

Also clean up some formatting and typos

(cherry picked from commit ef1d561)
(cherry picked from commit ba2e112)
(cherry picked from commit 5024cf8)
The ci_build parsing will now drop the
revision portion of the requested python
version targets to build for, since users
were passing in old buggy versions.

Using only major.minor will result in the latest
of the minor series being used, and won't affect
any build outputs like bytecode or ABI bindings.
Those are tied to major.minor versions of CPython.

(cherry picked from commit 5bf0875)
@mrodden mrodden force-pushed the find-pyversion-at-build-time-0.5.0 branch from eeca23c to 8c1eb0a Compare March 28, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants