forked from jax-ml/jax
-
Notifications
You must be signed in to change notification settings - Fork 4
CI: 04/14/25 upstream sync #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rocm-repo-management-api-2
wants to merge
723
commits into
rocm-main
Choose a base branch
from
ci-upstream-sync-171_1
base: rocm-main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tewidth. PiperOrigin-RevId: 743933866
PiperOrigin-RevId: 743953606
…s rather than #elems. PiperOrigin-RevId: 743953910
…efore checking it's not too long, so that e.g. `my_1d_array[:, ...]` can be treated as a slice rather than generating a gather operation. PiperOrigin-RevId: 743986126
PiperOrigin-RevId: 743990366
…vial PiperOrigin-RevId: 743993611
…st.py PiperOrigin-RevId: 744000229
PiperOrigin-RevId: 744007532
We need to be careful not to destroy Python objects while using a Python 3.13- critical section to protect C++ state. The critical section might be released when calling back into Python code (much as the GIL may be released in GIL mode). In this code Key is kept alive by the function already, but the Value may be deleted before the hash table updates are done. PiperOrigin-RevId: 744008939
Imported from GitHub PR jax-ml#26906 Allows overriding the slice index used by XLA. More explicit control over which slice a device ends up in is desirable: - Various parts of the ecosystem equate slices with "devices communicating via fast interconnect". With the arrival of NVL72 we want devices managed by multiple hosts to form a single slice. - For debugging purposes it can be useful to allow devices on the same host (managed in separate processes) to be treated as different slices. For example, [Orbax](https://github.com/google/orbax)'s local checkpointing presumes the existence of at least two slices, so overriding the boot id will allow us to test local checkpointing on a single host. (Companion PR in XLA: openxla/xla#23347) Copybara import of the project: -- 45aa7ce by Georg Stefan Schmid <[email protected]>: [jax.distributed] Allow overriding XLA slice_index Merging this change closes jax-ml#26906 COPYBARA_INTEGRATE_REVIEW=jax-ml#26906 from gspschmid:gschmid/jax-override-boot-id 45aa7ce PiperOrigin-RevId: 744012253
PiperOrigin-RevId: 744077517
PiperOrigin-RevId: 744083257
PiperOrigin-RevId: 744089477
PiperOrigin-RevId: 744136969
http://github.com/openxla/xla/commit/8118a02a2d8af30563d2942818ddb7c07c373877. PiperOrigin-RevId: 744248817
to_elt must run in the parent context, while from_elt must run in the batching context. We previously had it precisely backward! Tests didn't catch it because our tests are extremely minimal, and in particular didn't check a to_elt that binds primitives.
http://github.com/openxla/xla/commit/3889bec6b7f48e304953a485b713e9982dff0441. PiperOrigin-RevId: 744444688
PiperOrigin-RevId: 744478350
PiperOrigin-RevId: 744480338
PiperOrigin-RevId: 744480358
PiperOrigin-RevId: 744480452
PiperOrigin-RevId: 744483310
C++ static initialization acquires an internal mutex. It is unsafe to call into Python code while holding that mutex, e.g., see the deadlock in https://gist.github.com/vfdev-5/826ef16c6cbc9f4d85466e8a348c3b5a However, in this case, there's a simpler thing we can do: eagerly initialize the ::type() values during module initialization, rather than on-demand. PiperOrigin-RevId: 744508279
…and `AbstractMesh` is not `jax.sharding.AxisType`. PiperOrigin-RevId: 744602037
This change also fixes the transpose handling in the lowering and completely removes the use of the TransposeTransform. Instead we rely on strides. If we don't discover any issues with this, we will remove the transpose transform also from the mlir dialect. PiperOrigin-RevId: 744618241
I removed `trivial_ctx` from the public `jax.interpreters.partial_eval` submodule without going through a deprecation cycle, because it is highly unlikely anyone is using it. PiperOrigin-RevId: 744645764
…ts/outputs This introduces version 4 of serialization, fully backwards compatible with versions 2 and 3. Fixes: jax-ml#24143
PiperOrigin-RevId: 744652508
PiperOrigin-RevId: 744659794
PiperOrigin-RevId: 746546870
Use a count of chips (or omit it if 1) rather than specifying an ICI topology. Examples: * tpu_v5e_1x1 -> tpu_v5e * tpu_v5e_4x2 -> tpu_v5e_x8 PiperOrigin-RevId: 746547477
PiperOrigin-RevId: 746564071
…thon as a patch, rolling back. Reverts b1c96d4 PiperOrigin-RevId: 746565341
These APIs are already broken on GPU and TPU by virtue of not being implemented in the PJRT C API, so it seems unlikely that they have any users. PiperOrigin-RevId: 746595857
This parameter is available from jax-ml#23040 and documented in https://docs.jax.dev/en/latest/_autosummary/jax.numpy.isin.html. PiperOrigin-RevId: 746606206
…uts as attention call. PiperOrigin-RevId: 746616128
…mization PiperOrigin-RevId: 746639385
PiperOrigin-RevId: 746645422
…king similar to Llama4. Llama4 uses (interleaved) chunk attention to support long context. PiperOrigin-RevId: 746661156
When we print explanations for tracing cache misses, we use traceback_util to ignore JAX-internal functions. Here we change the detection mechanism to use source_info_util, which has a more exhaustive list of JAX internals. This removes a lot of uninteresting explanations from a large benchmark. jax-fixit PiperOrigin-RevId: 746703003
We no longer have many different implicit types conforming to `Executable`, only `pxla.MeshExectuable` and `pxla.PmapExecutable`. Both are `XlaExecutable` subtypes. So define just one common base class, call it `Exectuable`, and inherit from just that in both concrete internal executable subtypes. PiperOrigin-RevId: 746706712
These are thin and their implementations can be inlined directly at call sites in `XlaExecutable`. Co-authored-by: Roy Frostig <[email protected]> PiperOrigin-RevId: 746716734
PiperOrigin-RevId: 746726071
We no longer have many different implicit types conforming to `Lowering`, only `pxla.MeshComputation` and `pxla.PmapComputation`. Both are `XlaLowering` subtypes. So define just one common base class, call it `Lowering`, and inherit from just that in both concrete internal computation/lowering subtypes. PiperOrigin-RevId: 746735857
PiperOrigin-RevId: 746803082
http://github.com/openxla/xla/commit/007ab7fd0d30d585b802efcad403863d94e8b1c9. PiperOrigin-RevId: 746816179
PiperOrigin-RevId: 747039766
http://github.com/openxla/xla/commit/01b33c6596f2afeefaf76233cbb43cf6de66c1c9. PiperOrigin-RevId: 747085967
PiperOrigin-RevId: 747106561
PiperOrigin-RevId: 747194404
PiperOrigin-RevId: 747242052
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Daily sync with upstream