Fix KeyError for bytes_reservable_limit on ROCm #588
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROCm's memory_stats() returns 'bytes_limit' instead of 'bytes_reservable_limit'. Add platform-specific handling to test_lax_full_like_efficient to support both CUDA and ROCm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ROCm's memory_stats() returns 'bytes_limit' instead of 'bytes_reservable_limit'. Add platform-specific handling to test_lax_full_like_efficient to support both CUDA and ROCm.
Motivation
The test
tests/multi_device_test.py::MultiDeviceTest::test_lax_full_like_efficientfails on ROCm withKeyError: 'bytes_reservable_limit'. This occurs because ROCm'smemory_stats()API returns different keys than CUDA's implementation. The goal is to make the test platform-agnostic and work correctly on both CUDA and ROCm platforms.Technical Details
The change adds platform detection using
jtu.is_device_rocm()to select the appropriate memory statistics key:mem_stats['bytes_limit']mem_stats['bytes_reservable_limit']Below is the screenshot of my test run results without and with fix.
