Skip to content

[BUG] Add sync_openai api_server #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hongxiayang merged 1 commit into from
Jan 22, 2025
Merged

[BUG] Add sync_openai api_server #365

hongxiayang merged 1 commit into from
Jan 22, 2025

Conversation

@tjtanaa
Copy link

@tjtanaa tjtanaa commented Jan 17, 2025 •
edited by github-actions bot
Loading

Add sync_openai/api_server.py

@gshtras
Copy link
Collaborator

gshtras commented Jan 17, 2025

Just a note. sync_openai was a temporary workaround by us to the official server being inefficient in the past
It's been discontinued since because keeping up with the API changes in the server was too high maintenance, and because it only supported the very basic workflow, a small subset of the official server features anyway.

@tjtanaa tjtanaa marked this pull request as ready for review January 22, 2025 11:48
@hongxiayang hongxiayang merged commit 080a4bf into ROCm:llama_fp8_12062024 Jan 22, 2025
7 checks passed
@tjtanaa tjtanaa deleted the sync_api_server branch January 23, 2025 09:30
vllmellm pushed a commit to EmbeddedLLM/vllm-rocmfork that referenced this pull request Mar 12, 2025
@tjtanaa @vllmellm
add sync_openai api_server (ROCm#365)
a18b0c7 
(cherry picked from commit 080a4bf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hongxiayang hongxiayang hongxiayang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tjtanaa @gshtras @hongxiayang