Prepare for multiple algorithm support - #118
Merged
Merged
Conversation
Currently, you can switch between a serial or parallel/distributed run. If we want to support additional synchronization algorithms, a boolean is not enough. This commit introduces an enum that allows specifying what is the synchronization algorithm that a user wants to use. Signed-off-by: Alessandro Pellegrini <a.pellegrini@ing.uniroma2.it>
The test was expecting to find a parallel simulation configuration, but a sequential one was incorrectly configured. Signed-off-by: Alessandro Pellegrini <a.pellegrini@ing.uniroma2.it>
alessandropellegrini
marked this pull request as ready for review
June 25, 2025 17:52
|
Documentation coverage is 94.6% 👍 |
Piccions
approved these changes
Jun 27, 2025
Piccions
left a comment
Piccions
left a comment
Contributor
There was a problem hiding this comment.
A nice improvement to the interface, thanks @alessandropellegrini !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the configuration, we currently have a boolean to discriminate between a sequential and a time warp simulation. This PR converts the boolean to an explicit enum. In this way, we could introduce additional algorithms, selected by this enum.