Conversation
A lot of stuff has been removed to make things work. Major changes: - setup a git submodule for the ROOT-Sim core library - our custom compiler is now written in a very simple C++ style - handmade vectors and dynamic strings removed - the basic llvm plugin that does function copy and substitution works with llvm 14, with both the legacy pass manager and the new one - CMake magic is now in place to be able to contextually build the core library and install it together with the compiler, the rootsimcc library and the llvm plugins This thing incredibly works with a phold model. TODO: make things ACTUALLY work Criticism and suggestions are always welcome! Signed-off-by: Andrea Piccione <piccione@diag.uniroma1.it>
Contributor
Author
|
Main things TODO (I'm forgetting something for sure):
|
This was
linked to
issues
Jul 27, 2022
We are concentrating the release actions in a single monorepo that gathers together all the different projects. For this to work, we need different unique target names across the projects. This is already (mostly) true, except for the documentation target. This commit prepends the name of the repo to the doc target, for simplicity of management in the monorepo. Signed-off-by: Alessandro Pellegrini <a.pellegrini@ing.uniroma2.it>
Member
|
We should revamp this PR. It is functional to the release work that I am currently doing. |
Piccions
marked this pull request as ready for review
October 15, 2023 15:24
alessandropellegrini
requested changes
Oct 25, 2023
alessandropellegrini
left a comment
alessandropellegrini
left a comment
Member
There was a problem hiding this comment.
Thanks a lot!
As a minor note: the argparse library should go away from this repo, as we will be providing it as a separate library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of stuff has been removed to make things work. Major changes:
works with llvm 14, with both the legacy pass manager and the new one
library and install it together with the compiler, the rootsimcc
library and the llvm plugins
This thing incredibly works with a phold model.
TODO: make things ACTUALLY work